ci: fix SKIP_SHARED_PIPELINE leaking into reliability env pipeline#3682
Merged
ci: fix SKIP_SHARED_PIPELINE leaking into reliability env pipeline#3682
Conversation
The global SKIP_SHARED_PIPELINE=true introduced in #3679 is passed by GitLab to all downstream pipelines, including the cross-project deploy_to_reliability_env trigger. This caused trigger_unpack to be suppressed in the reliability env pipeline, breaking the PHP demo jobs (FrankePHP, Shopware, Symfony, Laravel) that depend on it. Fix: override deploy_to_reliability_env to explicitly pass SKIP_SHARED_PIPELINE=false, preventing the parent pipeline's suppression flag from affecting the downstream reliability env pipeline.
|
✨ Fix all issues with BitsAI or with Cursor
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #3682 +/- ##
==========================================
- Coverage 62.22% 62.10% -0.12%
==========================================
Files 141 141
Lines 13352 13352
Branches 1746 1746
==========================================
- Hits 8308 8292 -16
- Misses 4253 4266 +13
- Partials 791 794 +3 see 3 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
bwoebi
approved these changes
Mar 3, 2026
Leiyks
added a commit
that referenced
this pull request
Mar 4, 2026
Instead of including one-pipeline.locked.yml in the parent pipeline (which caused package-oci and other shared-pipeline jobs to leak into the parent), move the two supported-configurations validation jobs to generate-shared.php where the shared-pipeline include belongs. This removes all SKIP_SHARED_PIPELINE workarounds that were added as a band-aid in #3679, #3682, and supersedes #3687. The validate_supported_configurations_v2_local_file and update_central_configurations_version_range_v2 jobs now run in the shared-trigger child pipeline (shared-gen.yml), which includes one-pipeline.locked.yml for the required job templates.
3 tasks
Leiyks
added a commit
that referenced
this pull request
Mar 4, 2026
Instead of including one-pipeline.locked.yml in the parent pipeline (which caused package-oci and other shared-pipeline jobs to leak into the parent), move the two supported-configurations validation jobs to generate-shared.php where the shared-pipeline include belongs. This removes all SKIP_SHARED_PIPELINE workarounds that were added as a band-aid in #3679, #3682, and supersedes #3687. The validate_supported_configurations_v2_local_file and update_central_configurations_version_range_v2 jobs now run in the shared-trigger child pipeline (shared-gen.yml), which includes one-pipeline.locked.yml for the required job templates.
Leiyks
added a commit
that referenced
this pull request
Mar 5, 2026
Instead of including one-pipeline.locked.yml in the parent pipeline (which caused package-oci and other shared-pipeline jobs to leak into the parent), move the two supported-configurations validation jobs to generate-shared.php where the shared-pipeline include belongs. This removes all SKIP_SHARED_PIPELINE workarounds that were added as a band-aid in #3679, #3682, and supersedes #3687. The validate_supported_configurations_v2_local_file and update_central_configurations_version_range_v2 jobs now run in the shared-trigger child pipeline (shared-gen.yml), which includes one-pipeline.locked.yml for the required job templates.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The global SKIP_SHARED_PIPELINE=true introduced in #3679 is passed by GitLab to all downstream pipelines, including the cross-project deploy_to_reliability_env trigger. This caused trigger_unpack to be suppressed in the reliability env pipeline, breaking the PHP demo jobs (FrankePHP, Shopware, Symfony, Laravel) that depend on it.
Fix: override deploy_to_reliability_env to explicitly pass SKIP_SHARED_PIPELINE=false, preventing the parent pipeline's suppression flag from affecting the downstream reliability env pipeline.