Skip to content

ci: skip phpinfo language test on PHP <=8.1#3674

Merged
Leiyks merged 1 commit into
masterfrom
levi/phpinfo-backtracking
Feb 25, 2026
Merged

ci: skip phpinfo language test on PHP <=8.1#3674
Leiyks merged 1 commit into
masterfrom
levi/phpinfo-backtracking

Conversation

@morrisonlevi

@morrisonlevi morrisonlevi commented Feb 25, 2026

Copy link
Copy Markdown
Collaborator

Description

phpinfo.phpt on PHP 7.0-8.1 use older %A/%a expectations. With large phpinfo() output (tracer modules + CI environment variables), those patterns can hit regex backtracking issues and then the diff fails to match cleanly, causing "flaky" test failures.

Reviewer checklist

  • Test coverage seems ok.
  • Appropriate labels assigned.

@morrisonlevi
test(ci): skip phpinfo language test on PHP <=8.1
b7380ee 
phpinfo.phpt on PHP 7.0-8.1 use older %A/%a expectations. With large
phpinfo() output (tracer modules + CI environment variables), those
patterns can hit regex backtracking issues and then the diff fails to
match cleanly.
@morrisonlevi
morrisonlevi requested a review from a team as a code owner February 25, 2026 09:31
@datadog-official

datadog-official Bot commented Feb 25, 2026 •
edited by datadog-datadog-prod-us1-2 Bot
Loading

Copy link
Copy Markdown

⚠️ Tests

✨ Fix all issues with BitsAI or with Cursor

⚠️ Warnings

🧪 1028 Tests failed

testSearchPhpBinaries from integration.DDTrace\Tests\Integration\PHPInstallerTest (Datadog) (Fix with Cursor) 
DDTrace\Tests\Integration\PHPInstallerTest::testSearchPhpBinaries
Test code or tested code printed unexpected output: Searching for available php binaries, this operation might take a while.
testSimplePushAndProcess from laravel-58-test.DDTrace\Tests\Integrations\Laravel\V5_8\QueueTest (Datadog) (Fix with Cursor) 
Risky Test
phpvfscomposer://tests/vendor/phpunit/phpunit/phpunit:97
testSimplePushAndProcess from laravel-8x-test.DDTrace\Tests\Integrations\Laravel\V8_x\QueueTest (Datadog) (Fix with Cursor) 
DDTrace\Tests\Integrations\Laravel\V8_x\QueueTest::testSimplePushAndProcess
Test code or tested code printed unexpected output: spanLinksTraceId: 699ec2e00000000067441ed5d190d2a6
tid: 699ec2e000000000
hexProcessTraceId: 67441ed5d190d2a6
hexProcessSpanId: a6db921440b80ddd
processTraceId: 7441106388015698598
processSpanId: 12023364245878476253
View all

ℹ️ Info

❄️ No new flaky tests detected

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: b7380ee | Docs | Datadog PR Page | Was this helpful? Give us feedback!

bwoebi
bwoebi approved these changes Feb 25, 2026
View reviewed changes

@bwoebi bwoebi left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow. :-D

@Leiyks
Leiyks merged commit 07b618a into master Feb 25, 2026
2049 of 2072 checks passed
@Leiyks
Leiyks deleted the levi/phpinfo-backtracking branch February 25, 2026 11:15
@github-actions github-actions Bot added this to the 1.17.0 milestone Feb 25, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bwoebi bwoebi bwoebi approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

1.17.0

Development

Successfully merging this pull request may close these issues.

3 participants

@morrisonlevi @bwoebi @Leiyks