Skip to content

refactor(profiling): ErrnoBackup::new is safe#3659

Merged
morrisonlevi merged 1 commit intomasterfrom
levi/errno-backup
Feb 18, 2026
Merged

refactor(profiling): ErrnoBackup::new is safe#3659
morrisonlevi merged 1 commit intomasterfrom
levi/errno-backup

Conversation

@morrisonlevi
Copy link
Copy Markdown
Collaborator

@morrisonlevi morrisonlevi commented Feb 17, 2026 •
edited
Loading

Description

In code review, I noticed ErrnoBackup::new was safe, but it was already merged. So I fixed it, and added safety comments. We also verify that it is !Send, because it's not safe to write to another thread's errno, which would happen if we sent ErrnoBackup to another thread.

Reviewer checklist

  • Test coverage seems ok.
  • Appropriate labels assigned.

@github-actions github-actions Bot added the profiling Relates to the Continuous Profiler label Feb 17, 2026
@datadog-official
Copy link
Copy Markdown

datadog-official Bot commented Feb 17, 2026 •
edited
Loading

⚠️ Tests

✨ Fix all issues with BitsAI or with Cursor

⚠️ Warnings

🧪 1028 Tests failed

testSearchPhpBinaries from integration.DDTrace\Tests\Integration\PHPInstallerTest (Datadog) (Fix with Cursor) 
Risky Test
phpvfscomposer://tests/vendor/phpunit/phpunit/phpunit:97
testSimplePushAndProcess from laravel-58-test.DDTrace\Tests\Integrations\Laravel\V5_8\QueueTest (Datadog) (Fix with Cursor) 
DDTrace\Tests\Integrations\Laravel\V5_8\QueueTest::testSimplePushAndProcess
Test code or tested code printed unexpected output: spanLinksTraceId: 6995591f00000000bc0d14dd05d5c88d
tid: 6995591f00000000
hexProcessTraceId: bc0d14dd05d5c88d
hexProcessSpanId: 6781251150bf6d9f
processTraceId: 13550509793345915021
processSpanId: 7458283214201646495

phpvfscomposer://tests/vendor/phpunit/phpunit/phpunit:106

    testSimplePushAndProcess from laravel-8x-test.DDTrace\Tests\Integrations\Laravel\V8_x\QueueTest (Fix with Cursor)

View all

ℹ️ Info

❄️ No new flaky tests detected

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: 214d830 | Docs | Datadog PR Page | Was this helpful? Give us feedback!

@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Feb 17, 2026 •
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 62.20%. Comparing base (a9caaa0) to head (214d830).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3659      +/-   ##
==========================================
- Coverage   62.21%   62.20%   -0.02%     
==========================================
  Files         141      141              
  Lines       13387    13387              
  Branches     1753     1753              
==========================================
- Hits         8329     8327       -2     
- Misses       4260     4263       +3     
+ Partials      798      797       -1

see 1 file with indirect coverage changes

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a9caaa0...214d830. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@pr-commenter
Copy link
Copy Markdown

pr-commenter Bot commented Feb 17, 2026

Benchmarks [ profiler ]

Benchmark execution time: 2026-02-17 22:27:09

Comparing candidate commit 214d830 in PR branch levi/errno-backup with baseline commit a9caaa0 in branch master.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 29 metrics, 7 unstable metrics.

realFlowControl
realFlowControl approved these changes Feb 18, 2026
View reviewed changes
Copy link
Copy Markdown
Member

@realFlowControl realFlowControl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice cleanup

@morrisonlevi morrisonlevi marked this pull request as ready for review February 18, 2026 15:10
@morrisonlevi morrisonlevi requested review from a team as code owners February 18, 2026 15:10
@morrisonlevi morrisonlevi merged commit 6eb0128 into master Feb 18, 2026
2012 of 2071 checks passed
@morrisonlevi morrisonlevi deleted the levi/errno-backup branch February 18, 2026 16:12
@github-actions github-actions Bot added this to the 1.17.0 milestone Feb 18, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@realFlowControl realFlowControl realFlowControl approved these changes

Assignees

No one assigned

Labels

profiling Relates to the Continuous Profiler

Projects

None yet

Milestone

1.17.0

Development

Successfully merging this pull request may close these issues.

3 participants

@morrisonlevi @codecov-commenter @realFlowControl