Adds process tags to remote config payload by dubloom · Pull Request #3658 · DataDog/dd-trace-php

dubloom · 2026-02-17T17:57:30Z

Description

This PR implements this RFC for Remote Configuration.

Add process_tags to remote configuration payload.

This PR comes with this libdatadog PR: DataDog/libdatadog#1586

Reviewer checklist

Test coverage seems ok.
Appropriate labels assigned.

datadog-datadog-prod-us1 · 2026-02-17T18:03:49Z

⚠️ Tests

✨ Fix all issues with BitsAI or with Cursor

⚠️ Warnings

🧪 13 Tests failed

testSearchPhpBinaries from integration.DDTrace\Tests\Integration\PHPInstallerTest (Datadog) (Fix with Cursor)
Risky Test
phpvfscomposer://tests/vendor/phpunit/phpunit/phpunit:52
testSimplePushAndProcess from laravel-58-test.DDTrace\Tests\Integrations\Laravel\V5_8\QueueTest (Datadog) (Fix with Cursor)
DDTrace\Tests\Integrations\Laravel\V5_8\QueueTest::testSimplePushAndProcess
Test code or tested code printed unexpected output: spanLinksTraceId: 69bc42d000000000837ba6c6982d25a7
tid: 69bc42d000000000
hexProcessTraceId: 837ba6c6982d25a7
hexProcessSpanId: 48507b61fa9fd176
processTraceId: 9474349612990801319
processSpanId: 5210800429614485878

phpvfscomposer://tests/vendor/phpunit/phpunit/phpunit:106
testSimplePushAndProcess from laravel-8x-test.DDTrace\Tests\Integrations\Laravel\V8_x\QueueTest (Datadog) (Fix with Cursor)
DDTrace\Tests\Integrations\Laravel\V8_x\QueueTest::testSimplePushAndProcess
Test code or tested code printed unexpected output: spanLinksTraceId: 69bc4320000000001ecfbe2d0b128fd0
tid: 69bc432000000000
hexProcessTraceId: 1ecfbe2d0b128fd0
hexProcessSpanId: cc9f536899a9661d
processTraceId: 2220202241985515472
processSpanId: 14744595413754013213
View all

ℹ️ Info

No other issues found (see more)

❄️ No new flaky tests detected

_{This comment will be updated automatically if new data arrives.

🔗 Commit SHA: d8f785d | Docs | Datadog PR Page | Was this helpful? React with 👍/👎 or give us feedback!}

codecov-commenter · 2026-02-17T18:07:57Z

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 68.79%. Comparing base (f4ce0bf) to head (d8f785d).
⚠️ Report is 3 commits behind head on master.

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #3658      +/-   ##
==========================================
+ Coverage   68.74%   68.79%   +0.05%     
==========================================
  Files         166      166              
  Lines       19030    19030              
  Branches     1797     1797              
==========================================
+ Hits        13082    13092      +10     
+ Misses       5132     5125       -7     
+ Partials      816      813       -3

Flag	Coverage Δ
helper-rust-integration	`78.82% <ø> (ø)`
helper-rust-unit	`49.36% <ø> (ø)`

Flags with carried forward coverage won't be shown. Click here to find out more.
see 3 files with indirect coverage changes

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f4ce0bf...d8f785d. Read the comment docs.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

pr-commenter · 2026-02-17T19:16:39Z

Benchmarks [ tracer ]

Benchmark execution time: 2026-03-19 19:45:57

Comparing candidate commit d8f785d in PR branch dubloom/process-tags-rc with baseline commit f4ce0bf in branch master.

Found 1 performance improvements and 3 performance regressions! Performance is the same for 188 metrics, 2 unstable metrics.

scenario:ComposerTelemetryBench/benchTelemetryParsing-opcache

🟥 execution_time [+293.939ns; +1306.061ns] or [+2.370%; +10.533%]

scenario:HookBench/benchHookOverheadTraceFunction-opcache

🟩 execution_time [-6.838µs; -4.686µs] or [-4.033%; -2.764%]

scenario:MessagePackSerializationBench/benchMessagePackSerialization

🟥 execution_time [+2.324µs; +3.216µs] or [+2.233%; +3.090%]

scenario:MessagePackSerializationBench/benchMessagePackSerialization-opcache

🟥 execution_time [+5.993µs; +7.547µs] or [+5.682%; +7.156%]

Leiyks

lgtm 👍

...tegration/src/main/groovy/com/datadog/appsec/php/mock_agent/rem_cfg/RemoteConfigRequest.java

ext/sidecar.c

# What does this PR do? This PR allows to send process_tags through Remote Configuration payload. This PR comes with DataDog/dd-trace-php#3658 testing the feature in PHP Tracer. # Motivation Process tags must be sent by dd-trace-php for every product including RC. PHP tracer is using libdatadog for sending RC payload. # How to test the change? The changes is mainly validated in dd-trace-php. I also added a test here and modified the one impacted by the add of process_tags in the `.proto`. Co-authored-by: louis.tricot <[email protected]>

Signed-off-by: Bob Weinand <[email protected]>

bwoebi

Changes look good to me

Signed-off-by: Bob Weinand <[email protected]>

…dd-update * 'master' of github.com:DataDog/dd-trace-php: feat(sidecar): add thread mode as fallback connection for restricted environments (#3573) Migrate deprecated GitLab runner tags (#3715) Adds process tags to remote config payload (#3658) perf(config): cache sys getenv (#3670) Fixes the tag name for process tags (#3709) Fix debugger ephemerals handling (#3685) Fix #3651: Prevent crash during shutdown in Frankenphp (#3662) Add dynamic instrumentation and exception replay to startup logging (#3667) chore: bump bytes crate from 1.9.0 to 1.11.1 to address CVE-2026-25541 (#3669) Merge pull request #3701 from DataDog/brian.marks/add-ksr-tag ci: fix Windows job flakiness caused by dirty workspace (#3694) Fixup CI owner association (#3704) Add Rust rewrite of the AppSec helper alongside the C++ implementation Remove debug instruction Fix script order debug Fix exploration logic chore(ci): add final_status property on junit XML [APMSP-2610] Fix DD_TRACE_SYMFONY_HTTP_ROUTE=false Optimize Symfony http.route caching with path map approach

dubloom force-pushed the dubloom/process-tags-rc branch 2 times, most recently from eb4f124 to e242760 Compare March 9, 2026 13:41

dubloom mentioned this pull request Mar 9, 2026

feat(rc)!: add process_tags to remote config Target DataDog/libdatadog#1586

Merged

bump libdatadog

b9da34b

dubloom force-pushed the dubloom/process-tags-rc branch 2 times, most recently from af07faf to 2cb6fdb Compare March 10, 2026 09:54

Adds process tags to remote config payload

0a56d4b

dubloom force-pushed the dubloom/process-tags-rc branch from 2cb6fdb to 0a56d4b Compare March 10, 2026 09:56

dubloom marked this pull request as ready for review March 10, 2026 10:20

dubloom requested review from a team as code owners March 10, 2026 10:20

Merge branch 'master' into dubloom/process-tags-rc

b30e4f1

Leiyks approved these changes Mar 11, 2026

View reviewed changes

dubloom added 2 commits March 17, 2026 10:44

now process tags are passed as a vec

92e611a

fix appsec test

58f0a96

Leiyks reviewed Mar 17, 2026

View reviewed changes

...tegration/src/main/groovy/com/datadog/appsec/php/mock_agent/rem_cfg/RemoteConfigRequest.java Outdated Show resolved Hide resolved

ext/sidecar.c Show resolved Hide resolved

leiyks review

982f9bf

dubloom and others added 5 commits March 17, 2026 16:34

bump libdatadog

a88c9cf

Merge branch 'master' into dubloom/process-tags-rc

dc35f27

fix build

688bccf

Fix build

4d1a944

Signed-off-by: Bob Weinand <[email protected]>

Merge branch 'master' into dubloom/process-tags-rc

014caec

bwoebi mentioned this pull request Mar 18, 2026

feat(sidecar): add thread mode as fallback connection for restricted environments #3573

Merged

2 tasks

bwoebi force-pushed the dubloom/process-tags-rc branch from 959d576 to eca5577 Compare March 19, 2026 13:30

bwoebi approved these changes Mar 19, 2026

View reviewed changes

bwoebi force-pushed the dubloom/process-tags-rc branch 2 times, most recently from 8df6faf to a11948b Compare March 19, 2026 13:54

Fix build

a3550c4

Signed-off-by: Bob Weinand <[email protected]>

bwoebi force-pushed the dubloom/process-tags-rc branch 2 times, most recently from ee4cded to a3550c4 Compare March 19, 2026 15:20

cataphract added 2 commits March 19, 2026 18:27

Fix permission issue in appsec int build.gradle

ab7022e

Pin new version of image nginx-fpm-php-8.5-release-musl

d8f785d

bwoebi merged commit 2c440ab into master Mar 19, 2026
2074 checks passed

bwoebi deleted the dubloom/process-tags-rc branch March 19, 2026 21:52

github-actions bot added this to the 1.17.0 milestone Mar 19, 2026

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Adds process tags to remote config payload#3658

Adds process tags to remote config payload#3658
bwoebi merged 14 commits intomasterfrom
dubloom/process-tags-rc

dubloom commented Feb 17, 2026 •

edited

Loading

Uh oh!

datadog-datadog-prod-us1 bot commented Feb 17, 2026 •

edited by datadog-datadog-prod-us1-2 bot

Loading

Uh oh!

codecov-commenter commented Feb 17, 2026 •

edited

Loading

Uh oh!

pr-commenter bot commented Feb 17, 2026 •

edited

Loading

Uh oh!

Leiyks left a comment

Uh oh!

Uh oh!

Uh oh!

bwoebi left a comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Conversation

dubloom commented Feb 17, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Reviewer checklist

Uh oh!

datadog-datadog-prod-us1 bot commented Feb 17, 2026 • edited by datadog-datadog-prod-us1-2 bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

⚠️ Warnings

ℹ️ Info

Uh oh!

codecov-commenter commented Feb 17, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

pr-commenter bot commented Feb 17, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Benchmarks [ tracer ]

scenario:ComposerTelemetryBench/benchTelemetryParsing-opcache

scenario:HookBench/benchHookOverheadTraceFunction-opcache

scenario:MessagePackSerializationBench/benchMessagePackSerialization

scenario:MessagePackSerializationBench/benchMessagePackSerialization-opcache

Uh oh!

Leiyks left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

bwoebi left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

dubloom commented Feb 17, 2026 •

edited

Loading

datadog-datadog-prod-us1 bot commented Feb 17, 2026 •

edited by datadog-datadog-prod-us1-2 bot

Loading

codecov-commenter commented Feb 17, 2026 •

edited

Loading

pr-commenter bot commented Feb 17, 2026 •

edited

Loading