Fix possible race condition leading to a crash upon sidecar reconnect in ZTS#3655
Fix possible race condition leading to a crash upon sidecar reconnect in ZTS#3655
Conversation
… in ZTS Signed-off-by: Bob Weinand <[email protected]>
|
✨ Fix all issues with BitsAI or with Cursor
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #3655 +/- ##
==========================================
- Coverage 62.21% 62.20% -0.02%
==========================================
Files 141 141
Lines 13387 13387
Branches 1753 1753
==========================================
- Hits 8329 8327 -2
- Misses 4260 4263 +3
+ Partials 798 797 -1 see 1 file with indirect coverage changes Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
| #if ZTS | ||
| // With the current architecture of config it's not accessible via the TSRMLS_CACHE and thus may be actually invalid on the current thread. | ||
| // This is a known issue and will be fixed with refactor of the module_globals usage of config. The current behaviour is not perfect, but has to be considered acceptable. | ||
| if (zai_config_memoized_entries[DDTRACE_CONFIG_DD_DYNAMIC_INSTRUMENTATION_ENABLED].name_index >= 0) { |
There was a problem hiding this comment.
Should we make name_index atomic? I'm not sure exactly when/how this field is updated. The minit and first config things should be fine, not sure about how remote config works.
There was a problem hiding this comment.
That value is not supposed to be touched after first rinit anyway. So doesn't matter.
4 participants
See also comment added to the code.