Fix phpt asm standalone tests#3628
Merged
estringana merged 1 commit intomasterfrom Feb 9, 2026
Merged
Conversation
|
Leiyks
approved these changes
Feb 9, 2026
dubloom
pushed a commit
that referenced
this pull request
Feb 12, 2026
dubloom
added a commit
that referenced
this pull request
Feb 12, 2026
* Adds process tags to profiler uploader * remove useless utils function * remove empty lines and fix spelling * add function to ddtrace.sym * feat(CI: installer tests): fix installer tests by changing enabling check on appsec extension (#3604) Signed-off-by: Alexandre Rulleau <[email protected]> * refactor(profiling): use module globals for ZMM state (#3608) * refactor(profiling): use module globals for ZMM state * style: fix clippy warnings * Apply suggestions from code review Co-authored-by: Florian Engelhardt <[email protected]> * docs: note ZTS vs NTS differences --------- Co-authored-by: Florian Engelhardt <[email protected]> * refactor(profiling): extract Backtrace type (#3612) * refactor(profiling): extract Backtrace type In a future change, this may hold a refcount for another object, so we need to encapsulate it. * fix `test_collect_stack_sample` not running --------- Co-authored-by: Florian Engelhardt <[email protected]> * Propagate RELIABILITY_ENV_BRANCH to downstream pipeline (#3605) * Add simple_onboarding_appsec to SSI system tests (#3617) * Stores remote config requests in request-replayer (#3585) * feat(profiling): internal metrics for overhead (#3616) * feat(profiling): internal metrics for overhead * feat(profiling): move CPU time capture to include serialization for `ddprof_upload` for current profile exported Co-Authored-By: Claude Opus 4.5 <[email protected]> * feat(profiling): add CPU time tracking for `ddprof_time` thread Co-Authored-By: Claude Opus 4.5 <[email protected]> * feat(profiling): separate CPU time tracking per background thread Co-authored-by: Claude Opus 4.5 <[email protected]> --------- Co-authored-by: Florian Engelhardt <[email protected]> Co-authored-by: Claude Opus 4.5 <[email protected]> * fix(tracing): hook is_internal was backwards (#3625) * Fix phpt asm standalone tests (#3628) * fix readme file links (#3610) * test(language-tests): properly skip online tests and disabled soap_qname_crash.phpt on all version (#3632) Signed-off-by: Alexandre Rulleau <[email protected]> * Collect framework endpoints (#3548) * Only run publishing jobs when all dependent pipelines succeed (#3635) Signed-off-by: Bob Weinand <[email protected]> * chore(profiling): update libdatadog to 26 (#3633) * test(CI): manually handle git operation for windows jobs (#3634) * test(CI): add aggressive git cleanup on windows runner Signed-off-by: Alexandre Rulleau <[email protected]> * test(CI): add manual cleanup in before_script step Signed-off-by: Alexandre Rulleau <[email protected]> --------- Signed-off-by: Alexandre Rulleau <[email protected]> * feat(CI): add healthcheck to SQLSRV server setup (#3619) * feat(CI): add healthcheck to SQLSRV server setup Signed-off-by: Alexandre Rulleau <[email protected]> * chore: add troubleshooting script for SQLSRV Signed-off-by: Alexandre Rulleau <[email protected]> * feat: add explicit memory limit and paths Signed-off-by: Alexandre Rulleau <[email protected]> * chore: replace sqlsrv docker image Signed-off-by: Alexandre Rulleau <[email protected]> --------- Signed-off-by: Alexandre Rulleau <[email protected]> * fix(CI: test_metrics): add explicit flush in logging (#3637) * fix(logging): fsync crash logs before _Exit() to prevent data loss When a SIGSEGV occurs, the signal handler logs "Segmentation fault encountered" and then calls _Exit() which terminates the process immediately. Without fsync(), kernel write buffers may not be flushed to disk before termination, causing a race condition where the error log file is sometimes not created. This fix adds fsync() on Unix/Linux and _commit() on Windows after write() in ddtrace_log_with_time() to ensure crash logs persist to disk before process termination. The issue affects production (rare but possible during power loss, kernel panic, or I/O errors) and causes consistent test failures where tests check for log files immediately after crashes (before kernel writeback completes). Fixes flaky test_metrics SigSegVTest::testGet failures on Kubernetes where dd_php_error.log was not being created consistently. * fix(signals): move flush in sigsegv handler Signed-off-by: Alexandre Rulleau <[email protected]> --------- Signed-off-by: Alexandre Rulleau <[email protected]> * Adds process_tags to live debugger payloads (#3580) * init process tags for APM Co-Authored-By: PROFeNoM <[email protected]> * feat(process_tags): add process_tags to tracing payloads * small auto review and fix test * bwoebi review * fix test * Adds process_tags to live debugger payloads * temporary libdatadog bump * auto review * bump libdatadog * fix build * update makefile && make cbindgen * fixing test * fixing test * fix appsec tests --------- Co-authored-by: PROFeNoM <[email protected]> * chore(profiling): update libdatadog 26 to 27 (#3640) * chore(profiling): update libdatadog 26 to 27 * process tags were removed while rebasing to sign commit --------- Signed-off-by: Alexandre Rulleau <[email protected]> Signed-off-by: Bob Weinand <[email protected]> Co-authored-by: Florian Engelhardt <[email protected]> Co-authored-by: Alexandre Rulleau <[email protected]> Co-authored-by: Levi Morrison <[email protected]> Co-authored-by: Laplie Anderson <[email protected]> Co-authored-by: Alejandro Estringana Ruiz <[email protected]> Co-authored-by: Claude Opus 4.5 <[email protected]> Co-authored-by: Bob Weinand <[email protected]> Co-authored-by: PROFeNoM <[email protected]>
BridgeAR
pushed a commit
that referenced
this pull request
Feb 19, 2026
BridgeAR
pushed a commit
that referenced
this pull request
Feb 19, 2026
* Adds process tags to profiler uploader * remove useless utils function * remove empty lines and fix spelling * add function to ddtrace.sym * feat(CI: installer tests): fix installer tests by changing enabling check on appsec extension (#3604) Signed-off-by: Alexandre Rulleau <[email protected]> * refactor(profiling): use module globals for ZMM state (#3608) * refactor(profiling): use module globals for ZMM state * style: fix clippy warnings * Apply suggestions from code review Co-authored-by: Florian Engelhardt <[email protected]> * docs: note ZTS vs NTS differences --------- Co-authored-by: Florian Engelhardt <[email protected]> * refactor(profiling): extract Backtrace type (#3612) * refactor(profiling): extract Backtrace type In a future change, this may hold a refcount for another object, so we need to encapsulate it. * fix `test_collect_stack_sample` not running --------- Co-authored-by: Florian Engelhardt <[email protected]> * Propagate RELIABILITY_ENV_BRANCH to downstream pipeline (#3605) * Add simple_onboarding_appsec to SSI system tests (#3617) * Stores remote config requests in request-replayer (#3585) * feat(profiling): internal metrics for overhead (#3616) * feat(profiling): internal metrics for overhead * feat(profiling): move CPU time capture to include serialization for `ddprof_upload` for current profile exported Co-Authored-By: Claude Opus 4.5 <[email protected]> * feat(profiling): add CPU time tracking for `ddprof_time` thread Co-Authored-By: Claude Opus 4.5 <[email protected]> * feat(profiling): separate CPU time tracking per background thread Co-authored-by: Claude Opus 4.5 <[email protected]> --------- Co-authored-by: Florian Engelhardt <[email protected]> Co-authored-by: Claude Opus 4.5 <[email protected]> * fix(tracing): hook is_internal was backwards (#3625) * Fix phpt asm standalone tests (#3628) * fix readme file links (#3610) * test(language-tests): properly skip online tests and disabled soap_qname_crash.phpt on all version (#3632) Signed-off-by: Alexandre Rulleau <[email protected]> * Collect framework endpoints (#3548) * Only run publishing jobs when all dependent pipelines succeed (#3635) Signed-off-by: Bob Weinand <[email protected]> * chore(profiling): update libdatadog to 26 (#3633) * test(CI): manually handle git operation for windows jobs (#3634) * test(CI): add aggressive git cleanup on windows runner Signed-off-by: Alexandre Rulleau <[email protected]> * test(CI): add manual cleanup in before_script step Signed-off-by: Alexandre Rulleau <[email protected]> --------- Signed-off-by: Alexandre Rulleau <[email protected]> * feat(CI): add healthcheck to SQLSRV server setup (#3619) * feat(CI): add healthcheck to SQLSRV server setup Signed-off-by: Alexandre Rulleau <[email protected]> * chore: add troubleshooting script for SQLSRV Signed-off-by: Alexandre Rulleau <[email protected]> * feat: add explicit memory limit and paths Signed-off-by: Alexandre Rulleau <[email protected]> * chore: replace sqlsrv docker image Signed-off-by: Alexandre Rulleau <[email protected]> --------- Signed-off-by: Alexandre Rulleau <[email protected]> * fix(CI: test_metrics): add explicit flush in logging (#3637) * fix(logging): fsync crash logs before _Exit() to prevent data loss When a SIGSEGV occurs, the signal handler logs "Segmentation fault encountered" and then calls _Exit() which terminates the process immediately. Without fsync(), kernel write buffers may not be flushed to disk before termination, causing a race condition where the error log file is sometimes not created. This fix adds fsync() on Unix/Linux and _commit() on Windows after write() in ddtrace_log_with_time() to ensure crash logs persist to disk before process termination. The issue affects production (rare but possible during power loss, kernel panic, or I/O errors) and causes consistent test failures where tests check for log files immediately after crashes (before kernel writeback completes). Fixes flaky test_metrics SigSegVTest::testGet failures on Kubernetes where dd_php_error.log was not being created consistently. * fix(signals): move flush in sigsegv handler Signed-off-by: Alexandre Rulleau <[email protected]> --------- Signed-off-by: Alexandre Rulleau <[email protected]> * Adds process_tags to live debugger payloads (#3580) * init process tags for APM Co-Authored-By: PROFeNoM <[email protected]> * feat(process_tags): add process_tags to tracing payloads * small auto review and fix test * bwoebi review * fix test * Adds process_tags to live debugger payloads * temporary libdatadog bump * auto review * bump libdatadog * fix build * update makefile && make cbindgen * fixing test * fixing test * fix appsec tests --------- Co-authored-by: PROFeNoM <[email protected]> * chore(profiling): update libdatadog 26 to 27 (#3640) * chore(profiling): update libdatadog 26 to 27 * process tags were removed while rebasing to sign commit --------- Signed-off-by: Alexandre Rulleau <[email protected]> Signed-off-by: Bob Weinand <[email protected]> Co-authored-by: Florian Engelhardt <[email protected]> Co-authored-by: Alexandre Rulleau <[email protected]> Co-authored-by: Levi Morrison <[email protected]> Co-authored-by: Laplie Anderson <[email protected]> Co-authored-by: Alejandro Estringana Ruiz <[email protected]> Co-authored-by: Claude Opus 4.5 <[email protected]> Co-authored-by: Bob Weinand <[email protected]> Co-authored-by: PROFeNoM <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Tests were flaky
Reviewer checklist