Skip to content

Adds process_tags to telemetry payload#3627

Merged
dubloom merged 6 commits intomasterfrom
dubloom/process-tags-telemetry
Feb 17, 2026
Merged

Adds process_tags to telemetry payload#3627
dubloom merged 6 commits intomasterfrom
dubloom/process-tags-telemetry

Conversation

@dubloom
Copy link
Copy Markdown
Contributor

@dubloom dubloom commented Feb 6, 2026 •
edited
Loading

This PR implements this RFC for telemetry.

Add process_tags to process_tags payload. We should be able to set process_tags when configuring the sidecar (for sidecar reconnect) and we also add a function to be able to set them just after they are acquired

This PR comes with this libdatadog PR: DataDog/libdatadog#1459.

@datadog-official
Copy link
Copy Markdown

datadog-official bot commented Feb 6, 2026 •
edited
Loading

⚠️ Tests

✨ Fix all issues with Cursor

⚠️ Warnings

🧪 1028 Tests failed

    testSearchPhpBinaries from integration.DDTrace\Tests\Integration\PHPInstallerTest (Fix with Cursor)

    testSimplePushAndProcess from laravel-58-test.DDTrace\Tests\Integrations\Laravel\V5_8\QueueTest (Fix with Cursor)

testSimplePushAndProcess from laravel-8x-test.DDTrace\Tests\Integrations\Laravel\V8_x\QueueTest (Datadog) (Fix with Cursor) 
DDTrace\Tests\Integrations\Laravel\V8_x\QueueTest::testSimplePushAndProcess
Test code or tested code printed unexpected output: spanLinksTraceId: 6994284b00000000ffd3c22ae20aa55d
tid: 6994284b00000000
hexProcessTraceId: ffd3c22ae20aa55d
hexProcessSpanId: 63f57f451d020e1d
processTraceId: 18434291189194335581
processSpanId: 7202803113865121309
View all

ℹ️ Info

❄️ No new flaky tests detected

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: 72b5fd3 | Docs | Datadog PR Page | Was this helpful? Give us feedback!

@pr-commenter
Copy link
Copy Markdown

pr-commenter bot commented Feb 6, 2026 •
edited
Loading

Benchmarks [ tracer ]

Benchmark execution time: 2026-02-17 09:43:13

Comparing candidate commit 72b5fd3 in PR branch dubloom/process-tags-telemetry with baseline commit 72a021a in branch master.

Found 1 performance improvements and 0 performance regressions! Performance is the same for 193 metrics, 0 unstable metrics.

scenario:ComposerTelemetryBench/benchTelemetryParsing-opcache

  • 🟩 execution_time [-1.702µs; -0.498µs] or [-12.247%; -3.580%]

@dubloom dubloom force-pushed the dubloom/process-tags-telemetry branch from b2f20fa to e053e64 Compare February 12, 2026 16:14
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Feb 12, 2026 •
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 62.11%. Comparing base (72a021a) to head (72b5fd3).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3627      +/-   ##
==========================================
- Coverage   62.21%   62.11%   -0.11%     
==========================================
  Files         141      141              
  Lines       13387    13387              
  Branches     1753     1753              
==========================================
- Hits         8329     8315      -14     
- Misses       4260     4273      +13     
- Partials      798      799       +1

see 3 files with indirect coverage changes

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 72a021a...72b5fd3. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@dubloom dubloom changed the title Dubloom/process tags telemetry Adds process_tags to telemetry payload Feb 12, 2026
@dubloom dubloom marked this pull request as ready for review February 13, 2026 12:38
@dubloom dubloom requested review from a team as code owners February 13, 2026 12:38
@dubloom dubloom mentioned this pull request Feb 13, 2026
Merged
gh-worker-dd-mergequeue-cf854d bot pushed a commit to DataDog/libdatadog that referenced this pull request Feb 16, 2026
@dubloom
feat(telemetry)!: add process_tags to Application in telemetry (#1459)
b09abfb 
# What does this PR do?

This PR adds a `process_tags` field to the telemetry `Application` struct. This tag can be set during configuration or later (when the process_tags are acquired).

# Motivation

`dd-trace-php` needs to be send the process_tags for its telemetry according to this [RFC](https://docs.google.com/document/d/1AFdLUuVk70i0bJd5335-RxqsvwAV9ovAqcO2z5mEMbA/edit?tab=t.0#heading=h.s9l1lctqlg11). 
It is important to note that the tracer will set the configuration of its sidecar before we can retrieve the process_tags. That's why I created a function specifically to set the processs_tags.

# How to test the change?

The change is tested in dd-trace-php through this PR: DataDog/dd-trace-php#3627


Co-authored-by: louis.tricot <[email protected]>
bwoebi
bwoebi approved these changes Feb 17, 2026
View reviewed changes
Copy link
Copy Markdown
Collaborator

@bwoebi bwoebi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thanks!

@dubloom dubloom merged commit 7ed10a0 into master Feb 17, 2026
2070 checks passed
@dubloom dubloom deleted the dubloom/process-tags-telemetry branch February 17, 2026 12:42
@github-actions github-actions bot added this to the 1.17.0 milestone Feb 17, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bwoebi bwoebi bwoebi approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

1.17.0

Development

Successfully merging this pull request may close these issues.

3 participants

@dubloom @codecov-commenter @bwoebi