build(profiling): clean up cfg checks for MSRV 1.80+#3601
build(profiling): clean up cfg checks for MSRV 1.80+#3601morrisonlevi merged 2 commits intomasterfrom
Conversation
|
Benchmarks [ profiler ]Benchmark execution time: 2026-01-27 18:13:18 Comparing candidate commit f1806dd in PR branch Found 1 performance improvements and 2 performance regressions! Performance is the same for 26 metrics, 7 unstable metrics. scenario:php-profiler-timeline-memory-control
scenario:walk_stack/1
|
realFlowControl
left a comment
There was a problem hiding this comment.
Nice, I guess we can also remove the rustc_version dependency from the Cargo.toml now?
[build-dependencies]
bindgen = { version = \"0.69.4\" }
cc = { version = \"1.0\" }
-
-# We can remove this when we're using Rust 1.80+
-rustc_version = \"0.4\"
Yes, I dropped this! Nice eye. |
Description
We migrated to Rust 1.84 in #3299, which was 7 months ago. Time to clean it up.
Reviewer checklist