Skip to content

test(profiling): fix linking by removing recently added test#3570

Merged
morrisonlevi merged 1 commit intomasterfrom
levi/fix-cargo-test
Jan 13, 2026
Merged

test(profiling): fix linking by removing recently added test#3570
morrisonlevi merged 1 commit intomasterfrom
levi/fix-cargo-test

Conversation

@morrisonlevi
Copy link
Copy Markdown
Collaborator

@morrisonlevi morrisonlevi commented Jan 13, 2026

Description

This reverts commit fa1f099. The issue is that ddog_php_test_create_fake_zend_function_with_name_len creates a dependency on _emalloc by using zend_string_alloc and then we fail to link in some cases.

This went unnoticed due to merge order.

If we want to fix it "properly" then we need to link in the embed SAPI or similar to our tests, which seems like quite a bit of work for right now.

Reviewer checklist

  • Test coverage seems ok.
  • Appropriate labels assigned.

@morrisonlevi morrisonlevi requested a review from a team as a code owner January 13, 2026 02:00
@morrisonlevi morrisonlevi changed the title Revert "Add tests for function name length" test(profiling): fix linking by removing recently added test Jan 13, 2026
@morrisonlevi morrisonlevi added the profiling Relates to the Continuous Profiler label Jan 13, 2026
@datadog-official
Copy link
Copy Markdown

datadog-official Bot commented Jan 13, 2026 •
edited
Loading

⚠️ Tests

✨ Fix all issues with Cursor

⚠️ Warnings

🧪 2063 Tests failed

    testSearchPhpBinaries from integration.DDTrace\Tests\Integration\PHPInstallerTest (Fix with Cursor)

    testSimplePushAndProcess from laravel-58-test.DDTrace\Tests\Integrations\Laravel\V5_8\QueueTest (Fix with Cursor)

testSimplePushAndProcess from laravel-8x-test.DDTrace\Tests\Integrations\Laravel\V8_x\QueueTest (Datadog) (Fix with Cursor) 
DDTrace\Tests\Integrations\Laravel\V8_x\QueueTest::testSimplePushAndProcess
Test code or tested code printed unexpected output: spanLinksTraceId: 6965a9fa0000000066f78801d795d123
tid: 6965a9fa00000000
hexProcessTraceId: 66f78801d795d123
hexProcessSpanId: ddc4f34140090892
processTraceId: 7419548452609446179
processSpanId: 15980164839390120082
View all

ℹ️ Info

❄️ No new flaky tests detected

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: e30a526 | Docs | Datadog PR Page | Was this helpful? Give us feedback!

@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Jan 13, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 61.90%. Comparing base (60cd2c7) to head (e30a526).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3570      +/-   ##
==========================================
+ Coverage   61.81%   61.90%   +0.09%     
==========================================
  Files         140      140              
  Lines       13281    13281              
  Branches     1758     1758              
==========================================
+ Hits         8209     8221      +12     
+ Misses       4282     4272      -10     
+ Partials      790      788       -2

see 2 files with indirect coverage changes

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 60cd2c7...e30a526. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@pr-commenter
Copy link
Copy Markdown

pr-commenter Bot commented Jan 13, 2026

Benchmarks [ profiler ]

Benchmark execution time: 2026-01-13 02:11:31

Comparing candidate commit e30a526 in PR branch levi/fix-cargo-test with baseline commit 60cd2c7 in branch master.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 30 metrics, 6 unstable metrics.

@morrisonlevi morrisonlevi merged commit 4a26042 into master Jan 13, 2026
1904 of 2010 checks passed
@morrisonlevi morrisonlevi deleted the levi/fix-cargo-test branch January 13, 2026 02:28
@github-actions github-actions Bot added this to the 1.16.0 milestone Jan 13, 2026
realFlowControl added a commit that referenced this pull request Jan 13, 2026
@realFlowControl
Revert "test(profiling): fix linking by removing recently added test (#…
33452a6 
…3570)"

This reverts commit 4a26042.
@realFlowControl realFlowControl mentioned this pull request Jan 13, 2026
Merged
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bwoebi bwoebi bwoebi approved these changes

Assignees

No one assigned

Labels

profiling Relates to the Continuous Profiler

Projects

None yet

Milestone

1.16.0

Development

Successfully merging this pull request may close these issues.

3 participants

@morrisonlevi @codecov-commenter @bwoebi