fix(profiling): crash in ddtrace_get_profiling_context#3563
Merged
morrisonlevi merged 1 commit intomasterfrom Jan 12, 2026
Merged
fix(profiling): crash in ddtrace_get_profiling_context#3563morrisonlevi merged 1 commit intomasterfrom
morrisonlevi merged 1 commit intomasterfrom
Conversation
|
realFlowControl
approved these changes
Jan 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This crash shows that if a span is closed and an allocation takes place, then it's possible for the allocation profiler to dereference a null pointer. GENERALLY, this pointer is not null, it's just a sort of weird edge:
You can use this code with a
datadog.profiling.allocation_sample_distance=1to verify this, but I struggled to make a test and reproduce this without patching code:This crash was detected roughly 786 in the past week.
Reviewer checklist