Skip to content

fix(packaging): update fpm version from 1.15.1 to 1.17.0#3555

Merged
Leiyks merged 1 commit intomasterfrom
leiyks/3529
Jan 13, 2026
Merged

fix(packaging): update fpm version from 1.15.1 to 1.17.0#3555
Leiyks merged 1 commit intomasterfrom
leiyks/3529

Conversation

@Leiyks
Copy link
Copy Markdown
Contributor

@Leiyks Leiyks commented Jan 5, 2026 •
edited
Loading

Description

Problem

DataDog PHP tracer packages fail to install on Alpine Linux 3.23 with the error:
ERROR: datadog-php-tracer_1.14.1_aarch64.apk: v2 package format error

Root Cause

Alpine 3.23 introduced apk-tools v3.0.0, which enforces stricter APK v2 package validation. The new version requires a datahash field in the package's PKGINFO file - a SHA256 hash of the gzipped data.tar that's validated post-installation. Packages built with fpm 1.17.0 don't include this field, causing validation failures.

Solution

Add a patch with fpm_apk_alpine323.patch that:

  • Generates SHA256 hash of the gzipped data.tar
  • Calls hash_datatar() before calculating datahash, since hash_datatar modifies the tar by adding PAX headers with file checksums
  • Sets mtime=0 to ensure deterministic compression output (required for datahash to match the actual package data)
  • Add datahash to PKGINFO by writing datahash = <sha256> field for Alpine 3.23+ validation

Fixes #3529

@Leiyks Leiyks force-pushed the leiyks/3529 branch 3 times, most recently from d503645 to d962ab4 Compare January 5, 2026 16:08
@Leiyks Leiyks marked this pull request as ready for review January 5, 2026 16:15
@Leiyks Leiyks requested a review from a team as a code owner January 5, 2026 16:15
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Jan 5, 2026 •
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 61.81%. Comparing base (4a26042) to head (13fc8f5).

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #3555   +/-   ##
=======================================
  Coverage   61.81%   61.81%           
=======================================
  Files         140      140           
  Lines       13281    13281           
  Branches     1758     1758           
=======================================
  Hits         8209     8209           
  Misses       4282     4282           
  Partials      790      790

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4a26042...13fc8f5. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@datadog-official
Copy link
Copy Markdown

datadog-official Bot commented Jan 13, 2026 •
edited by datadog-datadog-prod-us1 Bot
Loading

⚠️ Tests

✨ Fix all issues with Cursor

⚠️ Warnings

🧪 2063 Tests failed

testSearchPhpBinaries from integration.DDTrace\Tests\Integration\PHPInstallerTest (Datadog) (Fix with Cursor) 
DDTrace\Tests\Integration\PHPInstallerTest::testSearchPhpBinaries
Test code or tested code printed unexpected output: Searching for available php binaries, this operation might take a while.

    testSimplePushAndProcess from laravel-58-test.DDTrace\Tests\Integrations\Laravel\V5_8\QueueTest (Fix with Cursor)

testSimplePushAndProcess from laravel-8x-test.DDTrace\Tests\Integrations\Laravel\V8_x\QueueTest (Datadog) (Fix with Cursor) 
DDTrace\Tests\Integrations\Laravel\V8_x\QueueTest::testSimplePushAndProcess
Test code or tested code printed unexpected output: spanLinksTraceId: 6966230100000000e5af448bcba91ded
tid: 6966230100000000
hexProcessTraceId: e5af448bcba91ded
hexProcessSpanId: 73bd79c5396411af
processTraceId: 16550522522817863149
processSpanId: 8339955972938404271
View all

ℹ️ Info

❄️ No new flaky tests detected

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: 13fc8f5 | Docs | Datadog PR Page | Was this helpful? Give us feedback!

bwoebi
bwoebi approved these changes Jan 13, 2026
View reviewed changes
Copy link
Copy Markdown
Collaborator

@bwoebi bwoebi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Looks good to me.

@Leiyks Leiyks merged commit 9331022 into master Jan 13, 2026
2005 of 2008 checks passed
@Leiyks Leiyks deleted the leiyks/3529 branch January 13, 2026 13:12
@github-actions github-actions Bot added this to the 1.16.0 milestone Jan 13, 2026
@hertznsk hertznsk mentioned this pull request Jan 30, 2026
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bwoebi bwoebi bwoebi approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

1.16.0

Development

Successfully merging this pull request may close these issues.

[Bug]: APK package format error

3 participants

@Leiyks @codecov-commenter @bwoebi