feat(PDO): correct a bug on prepared statement regarding DBM correlation#3545
Merged
feat(PDO): correct a bug on prepared statement regarding DBM correlation#3545
Conversation
Leiyks
force-pushed
the
leiyks/APMS-17965
branch
from
4d7e79e to
68bf5c5
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #3545 +/- ##
==========================================
- Coverage 61.78% 61.64% -0.14%
==========================================
Files 139 139
Lines 13051 13051
Branches 1712 1712
==========================================
- Hits 8063 8045 -18
- Misses 4225 4241 +16
- Partials 763 765 +2 see 4 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
Benchmarks [ tracer ]Benchmark execution time: 2025-12-30 17:21:12 Comparing candidate commit 753738a in PR branch Found 5 performance improvements and 8 performance regressions! Performance is the same for 180 metrics, 1 unstable metrics. scenario:MessagePackSerializationBench/benchMessagePackSerialization
scenario:MessagePackSerializationBench/benchMessagePackSerialization-opcache
scenario:PDOBench/benchPDOOverhead
scenario:PDOBench/benchPDOOverhead-opcache
scenario:PDOBench/benchPDOOverheadWithDBM
scenario:PDOBench/benchPDOOverheadWithDBM-opcache
scenario:SamplingRuleMatchingBench/benchGlobMatching1
scenario:SamplingRuleMatchingBench/benchRegexMatching1
scenario:SamplingRuleMatchingBench/benchRegexMatching2
scenario:SamplingRuleMatchingBench/benchRegexMatching3
scenario:SamplingRuleMatchingBench/benchRegexMatching4
scenario:SpanBench/benchOpenTelemetryAPI
scenario:TraceSerializationBench/benchSerializeTrace
|
Leiyks
force-pushed
the
leiyks/APMS-17965
branch
5 times, most recently
from
c1810e9 to
753738a
Compare
Leiyks
force-pushed
the
leiyks/APMS-17965
branch
from
753738a to
86ffb66
Compare
Leiyks
force-pushed
the
leiyks/APMS-17965
branch
5 times, most recently
from
aba777b to
fc4db39
Compare
Signed-off-by: Alexandre Rulleau <[email protected]>
Leiyks
force-pushed
the
leiyks/APMS-17965
branch
from
fc4db39 to
c45a6f6
Compare
bwoebi
approved these changes
Jan 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Problem
DBM correlation was broken for PDO prepared statements. The traceparent SQL comment which DBM uses to correlate database queries with APM traces contained a span_id that didn't match the span representing the actual query execution.
Root Cause
When using prepared statements (PDO::prepare() + PDOStatement::execute()):
This prevented DBM from properly correlating database queries with their corresponding APM spans.
Solution
Following the RFC we now use SERVICE mode (DBM_PROPAGATION_SERVICE) for prepared statements instead of FULL mode.