fix(telemetry): cap dependency name length to copied bytes#3538
Merged
morrisonlevi merged 1 commit intomasterfrom Dec 18, 2025
Merged
fix(telemetry): cap dependency name length to copied bytes#3538morrisonlevi merged 1 commit intomasterfrom
morrisonlevi merged 1 commit intomasterfrom
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #3538 +/- ##
==========================================
- Coverage 61.74% 61.73% -0.02%
==========================================
Files 143 143
Lines 13045 13045
Branches 1704 1704
==========================================
- Hits 8055 8053 -2
- Misses 4228 4231 +3
+ Partials 762 761 -1 see 1 file with indirect coverage changes Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
Benchmarks [ tracer ]Benchmark execution time: 2025-12-18 02:46:04 Comparing candidate commit bfb7ae6 in PR branch Found 1 performance improvements and 2 performance regressions! Performance is the same for 191 metrics, 0 unstable metrics. scenario:ComposerTelemetryBench/benchTelemetryParsing
scenario:MessagePackSerializationBench/benchMessagePackSerialization-opcache
scenario:TraceSerializationBench/benchSerializeTrace
|
Leiyks
approved these changes
Dec 18, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Example numbers for bug:
namelen = 500(module name is 500 chars long)copylen = min(256, 500) = 256Memory we actually have in the stack buffer:
"ext-"+ 256 bytes of name = 260 bytes totalBut we were sending:
CharSlice.len = namelen + 4 = 504So Rust would try to read 504 bytes from a buffer that only contains 260 valid bytes, causing an out-of-bounds read.
I am not aware of any crashes that are happening directly because of this, meaning, I'm not aware of any modules which have names that long. However, this function is involved in crash reports, so that's where the additional scrutiny is coming from.
Reviewer checklist