fix: stream context integration with HTTP method#3534
Merged
morrisonlevi merged 3 commits intomasterfrom Dec 18, 2025
Merged
Conversation
2 tasks
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #3534 +/- ##
==========================================
- Coverage 61.74% 61.65% -0.10%
==========================================
Files 143 143
Lines 13045 13045
Branches 1704 1704
==========================================
- Hits 8055 8043 -12
- Misses 4228 4238 +10
- Partials 762 764 +2 see 2 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
Benchmarks [ tracer ]Benchmark execution time: 2025-12-17 18:13:45 Comparing candidate commit 788475b in PR branch Found 1 performance improvements and 7 performance regressions! Performance is the same for 184 metrics, 2 unstable metrics. scenario:MessagePackSerializationBench/benchMessagePackSerialization
scenario:MessagePackSerializationBench/benchMessagePackSerialization-opcache
scenario:SamplingRuleMatchingBench/benchRegexMatching1
scenario:SamplingRuleMatchingBench/benchRegexMatching2
scenario:SamplingRuleMatchingBench/benchRegexMatching3
scenario:SamplingRuleMatchingBench/benchRegexMatching4
scenario:SpanBench/benchOpenTelemetryAPI
scenario:TraceSerializationBench/benchSerializeTrace
|
This reverts commit 523ec89.
Leiyks
approved these changes
Dec 18, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The streams context uses the options array to set the HTTP method like so:
But the code wasn't looking for
$options['http']['method'], it was looking for$options['method'].I found this because the previous code would have had an ASAN violation, but due to this bug, it wouldn't ever execute. You can see the CI runs for the middle commit that show the ASAN failure.
Reviewer checklist