Skip to content

Add metrics for extension connections#3527

Merged
cataphract merged 1 commit intomasterfrom
glopes/appsec-ext-conn-metrics
Dec 15, 2025
Merged

Add metrics for extension connections#3527
cataphract merged 1 commit intomasterfrom
glopes/appsec-ext-conn-metrics

Conversation

@cataphract
Copy link
Copy Markdown
Contributor

@cataphract cataphract commented Dec 10, 2025

Description

Tracks successful, failed, and closed connections.

Reviewer checklist

  • Test coverage seems ok.
  • Appropriate labels assigned.

@cataphract cataphract requested a review from a team as a code owner December 10, 2025 17:30
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Dec 10, 2025

Codecov Report

❌ Patch coverage is 70.00000% with 9 lines in your changes missing coverage. Please review.
✅ Project coverage is 61.66%. Comparing base (01a8843) to head (3185437).

Files with missing lines Patch % Lines
appsec/src/extension/telemetry.c 66.66% 7 Missing and 2 partials ⚠️

❌ Your patch status has failed because the patch coverage (70.00%) is below the target coverage (90.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3527      +/-   ##
==========================================
- Coverage   61.73%   61.66%   -0.08%     
==========================================
  Files         143      143              
  Lines       13008    13038      +30     
  Branches     1702     1704       +2     
==========================================
+ Hits         8031     8040       +9     
- Misses       4218     4235      +17     
- Partials      759      763       +4
Files with missing lines Coverage Δ
appsec/src/extension/configuration.h 100.00% <ø> (ø)
appsec/src/extension/helper_process.c 52.75% <100.00%> (+0.46%) ⬆️
appsec/src/extension/telemetry.c 77.55% <66.66%> (-13.36%) ⬇️

... and 2 files with indirect coverage changes

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 01a8843...3185437. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@pr-commenter
Copy link
Copy Markdown

pr-commenter Bot commented Dec 10, 2025

Benchmarks [ appsec ]

Benchmark execution time: 2025-12-10 18:06:29

Comparing candidate commit 3185437 in PR branch glopes/appsec-ext-conn-metrics with baseline commit 01a8843 in branch master.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 0 unstable metrics.

@cataphract cataphract merged commit 6f3efe5 into master Dec 15, 2025
2008 of 2009 checks passed
@cataphract cataphract deleted the glopes/appsec-ext-conn-metrics branch December 15, 2025 12:59
@github-actions github-actions Bot added this to the 1.15.0 milestone Dec 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@estringana estringana estringana approved these changes

Assignees

No one assigned

Labels

area:asm tracing

Projects

None yet

Milestone

1.15.0

Development

Successfully merging this pull request may close these issues.

3 participants

@cataphract @codecov-commenter @estringana