[AAP] Minor fixes and improvements to file descriptor reclamation#3526
[AAP] Minor fixes and improvements to file descriptor reclamation#3526cataphract merged 4 commits intomasterfrom
Conversation
Codecov Report❌ Patch coverage is ❌ Your patch status has failed because the patch coverage (3.70%) is below the target coverage (90.00%). You can increase the patch coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## master #3526 +/- ##
==========================================
- Coverage 61.73% 61.63% -0.11%
==========================================
Files 143 143
Lines 13008 13015 +7
Branches 1702 1702
==========================================
- Hits 8031 8022 -9
- Misses 4218 4231 +13
- Partials 759 762 +3
... and 3 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
| : sock_(::socket(AF_UNIX, SOCK_STREAM, 0)) | ||
| { | ||
| // NOLINTNEXTLINE(android-cloexec-socket,cppcoreguidelines-prefer-member-initializer) | ||
| sock_ = ::socket(AF_UNIX, SOCK_STREAM, 0); |
There was a problem hiding this comment.
it would be better to introduce an owned_fd class and also remove the destructor
Benchmarks [ appsec ]Benchmark execution time: 2025-12-10 17:35:02 Comparing candidate commit bdb3ffe in PR branch Found 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 0 unstable metrics. |
cataphract
force-pushed
the
anilm3/appsec-fd-fixes
branch
from
14a1d2c to
bdb3ffe
Compare
cataphract
force-pushed
the
anilm3/appsec-fd-fixes
branch
2 times, most recently
from
bdb3ffe to
f49dd68
Compare
3 participants
Description
Reviewer checklist