Skip to content

Add Custom Data Classification#3524

Merged
estringana merged 2 commits intomasterfrom
estringana/enable-custom-data-classification
Dec 10, 2025
Merged

Add Custom Data Classification#3524
estringana merged 2 commits intomasterfrom
estringana/enable-custom-data-classification

Conversation

@estringana
Copy link
Copy Markdown
Contributor

@estringana estringana commented Dec 9, 2025

Description

Add dustom data classification capabilities

Reviewer checklist

  • Test coverage seems ok.
  • Appropriate labels assigned.

@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Dec 9, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 61.73%. Comparing base (373e64d) to head (c76bea6).
⚠️ Report is 313 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3524      +/-   ##
==========================================
- Coverage   61.75%   61.73%   -0.03%     
==========================================
  Files         143      143              
  Lines       13008    13008              
  Branches     1702     1702              
==========================================
- Hits         8033     8030       -3     
- Misses       4215     4219       +4     
+ Partials      760      759       -1     

see 1 file with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 373e64d...c76bea6. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@estringana estringana marked this pull request as ready for review December 9, 2025 12:00
@estringana estringana requested a review from a team as a code owner December 9, 2025 12:00
@estringana estringana requested a review from a team as a code owner December 9, 2025 12:07
@pr-commenter
Copy link
Copy Markdown

pr-commenter Bot commented Dec 9, 2025

Benchmarks [ tracer ]

Benchmark execution time: 2025-12-09 13:11:58

Comparing candidate commit c76bea6 in PR branch estringana/enable-custom-data-classification with baseline commit 373e64d in branch master.

Found 2 performance improvements and 2 performance regressions! Performance is the same for 189 metrics, 1 unstable metrics.

scenario:ComposerTelemetryBench/benchTelemetryParsing-opcache

  • 🟩 execution_time [-1.738µs; -0.862µs] or [-12.688%; -6.290%]

scenario:MessagePackSerializationBench/benchMessagePackSerialization

  • 🟥 execution_time [+2.154µs; +4.126µs] or [+2.098%; +4.019%]

scenario:MessagePackSerializationBench/benchMessagePackSerialization-opcache

  • 🟥 execution_time [+4.751µs; +7.289µs] or [+4.532%; +6.954%]

scenario:TraceSerializationBench/benchSerializeTrace

  • 🟩 execution_time [-43.889µs; -28.011µs] or [-9.842%; -6.281%]

@estringana estringana merged commit 01a8843 into master Dec 10, 2025
2006 of 2007 checks passed
@estringana estringana deleted the estringana/enable-custom-data-classification branch December 10, 2025 08:09
@github-actions github-actions Bot added this to the 1.15.0 milestone Dec 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants