Skip to content

appsec helper: add send timeouts#3518

Merged
cataphract merged 1 commit intomasterfrom
glopes/helper-timeout
Dec 9, 2025
Merged

appsec helper: add send timeouts#3518
cataphract merged 1 commit intomasterfrom
glopes/helper-timeout

Conversation

@cataphract
Copy link
Copy Markdown
Contributor

set_send_timeout was never used

Description

Reviewer checklist

  • Test coverage seems ok.
  • Appropriate labels assigned.

set_send_timeout was never used
@codecov-commenter
Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 61.66%. Comparing base (ca291a7) to head (f39ab3e).
⚠️ Report is 2 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3518      +/-   ##
==========================================
+ Coverage   61.65%   61.66%   +0.01%     
==========================================
  Files         143      143              
  Lines       13004    13008       +4     
  Branches     1702     1702              
==========================================
+ Hits         8017     8021       +4     
  Misses       4225     4225              
  Partials      762      762              
Files with missing lines Coverage Δ
appsec/src/helper/network/broker.cpp 85.13% <100.00%> (+0.84%) ⬆️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ca291a7...f39ab3e. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@pr-commenter
Copy link
Copy Markdown

pr-commenter Bot commented Dec 5, 2025

Benchmarks [ appsec ]

Benchmark execution time: 2025-12-05 16:01:33

Comparing candidate commit f39ab3e in PR branch glopes/helper-timeout with baseline commit ca291a7 in branch master.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 0 unstable metrics.

@pr-commenter
Copy link
Copy Markdown

pr-commenter Bot commented Dec 5, 2025

Benchmarks [ tracer ]

Benchmark execution time: 2025-12-05 16:31:00

Comparing candidate commit f39ab3e in PR branch glopes/helper-timeout with baseline commit ca291a7 in branch master.

Found 1 performance improvements and 8 performance regressions! Performance is the same for 185 metrics, 0 unstable metrics.

scenario:ComposerTelemetryBench/benchTelemetryParsing

  • 🟥 execution_time [+1.787µs; +2.613µs] or [+17.518%; +25.620%]

scenario:MessagePackSerializationBench/benchMessagePackSerialization

  • 🟥 execution_time [+4.501µs; +5.479µs] or [+4.493%; +5.469%]

scenario:MessagePackSerializationBench/benchMessagePackSerialization-opcache

  • 🟥 execution_time [+6.130µs; +8.110µs] or [+5.874%; +7.772%]

scenario:SamplingRuleMatchingBench/benchRegexMatching1

  • 🟥 execution_time [+105.639ns; +153.561ns] or [+9.050%; +13.155%]

scenario:SamplingRuleMatchingBench/benchRegexMatching2

  • 🟥 execution_time [+109.959ns; +173.841ns] or [+9.430%; +14.908%]

scenario:SamplingRuleMatchingBench/benchRegexMatching3

  • 🟥 execution_time [+98.933ns; +174.067ns] or [+8.467%; +14.897%]

scenario:SamplingRuleMatchingBench/benchRegexMatching4

  • 🟥 execution_time [+91.783ns; +144.417ns] or [+7.864%; +12.374%]

scenario:SpanBench/benchOpenTelemetryAPI

  • 🟥 mem_peak [+1.710MB; +1.716MB] or [+4.139%; +4.153%]

scenario:TraceSerializationBench/benchSerializeTrace

  • 🟩 execution_time [-39.552µs; -29.248µs] or [-8.745%; -6.466%]

@cataphract cataphract merged commit 373e64d into master Dec 9, 2025
2006 of 2008 checks passed
@cataphract cataphract deleted the glopes/helper-timeout branch December 9, 2025 10:37
@github-actions github-actions Bot added this to the 1.15.0 milestone Dec 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants