appsec: Fix segfault iterating mapping#3517
Merged
cataphract merged 2 commits intomasterfrom Dec 5, 2025
Merged
Conversation
Benchmarks [ appsec ]Benchmark execution time: 2025-12-05 12:07:26 Comparing candidate commit c4a714a in PR branch Found 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 0 unstable metrics. |
estringana
approved these changes
Dec 5, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
There were two reports of crashes inside the code iterating the tree map
msgpack::v3::adaptor::(anonymous namespace)::mapping(the node pointer becoming corrupted). While ultimately the cause of the crash could not be determined, change it to be a true const, with no initialization/deinitialization code associated in order to fix the problem (the variable now lives in .data.rel.ro).Reviewer checklist