perf: const-ify some logging thread-local variables#3513
Merged
realFlowControl merged 1 commit intomasterfrom Dec 2, 2025
Merged
perf: const-ify some logging thread-local variables#3513realFlowControl merged 1 commit intomasterfrom
realFlowControl merged 1 commit intomasterfrom
Conversation
Benchmarks [ tracer ]Benchmark execution time: 2025-12-02 01:07:22 Comparing candidate commit bfb5847 in PR branch Found 1 performance improvements and 0 performance regressions! Performance is the same for 193 metrics, 0 unstable metrics. scenario:TraceSerializationBench/benchSerializeTrace
|
realFlowControl
approved these changes
Dec 2, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Perf is not the real story here, but it's technically true. The rest is speculative:
TRACING_GUARDSis involved in some inexplicable crash reports. Making it const will simplify the runtime, because it no longer needs to lazily initialize the thread-local storage for it; see thread_local's docs. I am hoping that somehow that this helps, but there's no downside to trying.Reviewer checklist