fix(prof): fixed asserting length of INI#3508
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #3508 +/- ##
==========================================
+ Coverage 61.71% 61.78% +0.07%
==========================================
Files 142 142
Lines 12923 12923
Branches 1695 1695
==========================================
+ Hits 7975 7985 +10
+ Misses 4193 4186 -7
+ Partials 755 752 -3 see 3 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
realFlowControl
changed the title
Benchmarks [ profiler ]Benchmark execution time: 2025-11-28 12:51:00 Comparing candidate commit fe8ec9f in PR branch Found 0 performance improvements and 0 performance regressions! Performance is the same for 29 metrics, 7 unstable metrics. |
realFlowControl
changed the title
morrisonlevi
left a comment
morrisonlevi
left a comment
There was a problem hiding this comment.
Test failures look unrelated. Code change looks correct.
3 participants
Description
When converting the environment name to an INI name we asserted on the wrong length, using the
ZAI_CONFIG_ENTRIES_COUNT_MAX(300) instead of theZAI_CONFIG_NAME_BUFSIZ(60). So in theory we could have used ENV names for config options that result in INI names longer then the fixed 60 bytes buffer.Reviewer checklist