Skip to content

fix(profiler): update libdatadog to fix rust panic#3498

Merged
realFlowControl merged 2 commits intomasterfrom
florian/fix-obervations-assertion
Nov 26, 2025
Merged

fix(profiler): update libdatadog to fix rust panic#3498
realFlowControl merged 2 commits intomasterfrom
florian/fix-obervations-assertion

Conversation

@realFlowControl
Copy link
Copy Markdown
Member

Description

This updates libdatadog to the version from DataDog/libdatadog#1362 in order to fix the bug stated there and to kick of a CI

Reviewer checklist

  • Test coverage seems ok.
  • Appropriate labels assigned.

@pr-commenter
Copy link
Copy Markdown

pr-commenter Bot commented Nov 24, 2025

Benchmarks [ profiler ]

Benchmark execution time: 2025-11-25 13:40:05

Comparing candidate commit cd0f1c2 in PR branch florian/fix-obervations-assertion with baseline commit ddced7c in branch master.

Found 0 performance improvements and 5 performance regressions! Performance is the same for 23 metrics, 8 unstable metrics.

scenario:php-profiler-timeline-memory-control

  • 🟥 cpu_user_time [+31.047ms; +38.696ms] or [+5.147%; +6.415%]
  • 🟥 execution_time [+34.457ms; +40.449ms] or [+5.461%; +6.411%]

scenario:php-profiler-timeline-memory-with-profiler

  • 🟥 execution_time [+27.764ms; +44.012ms] or [+2.940%; +4.661%]

scenario:php-profiler-timeline-memory-with-profiler-and-timeline

  • 🟥 cpu_user_time [+41.573ms; +83.782ms] or [+2.656%; +5.354%]
  • 🟥 execution_time [+46.638ms; +59.292ms] or [+3.770%; +4.792%]

@realFlowControl realFlowControl force-pushed the florian/fix-obervations-assertion branch from 2d2525c to cd0f1c2 Compare November 25, 2025 13:22
@realFlowControl realFlowControl marked this pull request as ready for review November 25, 2025 13:23
@realFlowControl realFlowControl requested review from a team as code owners November 25, 2025 13:23
@codecov-commenter
Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 61.78%. Comparing base (ddced7c) to head (cd0f1c2).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3498      +/-   ##
==========================================
- Coverage   61.80%   61.78%   -0.02%     
==========================================
  Files         142      142              
  Lines       12923    12923              
  Branches     1695     1695              
==========================================
- Hits         7987     7985       -2     
- Misses       4183     4186       +3     
+ Partials      753      752       -1     

see 1 file with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ddced7c...cd0f1c2. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@realFlowControl realFlowControl changed the title update libdatadog for profiler fix(profiler): update libdatadog to fix rust panic Nov 26, 2025
@realFlowControl realFlowControl merged commit 0c35caf into master Nov 26, 2025
2002 of 2008 checks passed
@realFlowControl realFlowControl deleted the florian/fix-obervations-assertion branch November 26, 2025 08:20
@github-actions github-actions Bot added this to the 1.15.0 milestone Nov 26, 2025
realFlowControl added a commit that referenced this pull request Nov 26, 2025
* update libdatadog for profiler

* update libdatadog to v24.0.2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants