Clear client_ip on request_init#3496
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #3496 +/- ##
==========================================
- Coverage 61.88% 61.79% -0.10%
==========================================
Files 142 142
Lines 12904 12909 +5
Branches 1689 1690 +1
==========================================
- Hits 7986 7977 -9
- Misses 4159 4172 +13
- Partials 759 760 +1
... and 3 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
Benchmarks [ appsec ]Benchmark execution time: 2025-11-24 15:04:47 Comparing candidate commit b512139 in PR branch Found 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 0 unstable metrics. |
| } | ||
|
|
||
| if (_client_ip) { | ||
| mlog(dd_log_warning, "Client IP not cleared on prev request. Value %p", |
There was a problem hiding this comment.
Should this be a debug instead?
There was a problem hiding this comment.
for this to get here, sth strange that made request_shutdown not being executed must have happened. If this were common, we'd see a lot of crashes. So I think the warning is warranted.
3 participants
Description
Telemetry showed a crash when serializing the client ip. The data looks corrupted:
1.13.1:
Reviewer checklist