Fix double end hook run/segault when blocking in PHP 7.x#3490
Merged
cataphract merged 1 commit intomasterfrom Dec 5, 2025
Merged
Fix double end hook run/segault when blocking in PHP 7.x#3490cataphract merged 1 commit intomasterfrom
cataphract merged 1 commit intomasterfrom
Conversation
cataphract
force-pushed
the
glopes/hook-end-segfault-php7
branch
from
ebbc709 to
3421bbf
Compare
Benchmarks [ tracer ]Benchmark execution time: 2025-12-05 13:42:34 Comparing candidate commit 50eab8d in PR branch Found 2 performance improvements and 4 performance regressions! Performance is the same for 188 metrics, 0 unstable metrics. scenario:ComposerTelemetryBench/benchTelemetryParsing-opcache
scenario:MessagePackSerializationBench/benchMessagePackSerialization
scenario:MessagePackSerializationBench/benchMessagePackSerialization-opcache
scenario:PDOBench/benchPDOOverhead
scenario:PDOBench/benchPDOOverheadWithDBM
scenario:TraceSerializationBench/benchSerializeTrace
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #3490 +/- ##
==========================================
+ Coverage 61.65% 61.72% +0.07%
==========================================
Files 143 143
Lines 13004 13004
Branches 1702 1702
==========================================
+ Hits 8017 8027 +10
+ Misses 4225 4218 -7
+ Partials 762 759 -3 see 3 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
estringana
approved these changes
Dec 4, 2025
cataphract
force-pushed
the
glopes/hook-end-segfault-php7
branch
from
3421bbf to
3af54b5
Compare
cataphract
force-pushed
the
glopes/hook-end-segfault-php7
branch
from
3af54b5 to
50eab8d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
End hooks run twice if appsec blocks during one in PHP 7, possibly segfaulting.
Reviewer checklist