Conversation
…ige interruptible key
igoragoli
changed the title
Benchmarks [ profiler ]Benchmark execution time: 2025-11-18 12:57:12 Comparing candidate commit e8ac91b in PR branch Found 0 performance improvements and 2 performance regressions! Performance is the same for 27 metrics, 7 unstable metrics. scenario:php-profiler-timeline-memory-control
|
Benchmarks [ appsec ]Benchmark execution time: 2025-11-18 13:19:26 Comparing candidate commit e8ac91b in PR branch Found 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 0 unstable metrics. |
ddyurchenko
approved these changes
Nov 18, 2025
Leiyks
approved these changes
Nov 19, 2025
igoragoli
deleted the
augusto.deoliveira/apmsp-2369.ensure-correct-interrupt-policy
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
master(and when outside release branches for macrobenchmarks).I decided to set up rules as hidden jobs and use them with YAML anchors, since the macrobenchmark rules were set like this. There were other patterns being used (rules being directly written, or being used with
extends). Usingextendswouldn't work since it cannot merge arrays. Writing rules directly is entirely possible, but will make the job definitions large.The rules are large since we need to control both the job creation and interruption behaviors (which depend on entirely different conditions) with
rules(which unfortunately works on a first-match basis, without any possibility to nest rules in tidy if-elseif-else statements).APMSP-2369
#incident-45572
Testing: cancelled benchmarking jobs after adding a "test interruptibility" commit, e46ab82.
Reviewer checklist