fix(prof): early init default connector to fix env var race#3432
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #3432 +/- ##
==========================================
- Coverage 61.85% 61.74% -0.12%
==========================================
Files 141 141
Lines 12481 12481
Branches 1630 1630
==========================================
- Hits 7720 7706 -14
- Misses 4041 4054 +13
- Partials 720 721 +1 see 2 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
morrisonlevi
approved these changes
Sep 23, 2025
Benchmarks [ profiler ]Benchmark execution time: 2025-09-23 19:47:22 Comparing candidate commit 43cfc69 in PR branch Found 0 performance improvements and 9 performance regressions! Performance is the same for 19 metrics, 8 unstable metrics. scenario:php-profiler-exceptions-control
scenario:php-profiler-exceptions-with-profiler
scenario:php-profiler-exceptions-with-profiler-and-timeline
scenario:php-profiler-timeline-memory-control
scenario:php-profiler-timeline-memory-with-profiler
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This pr make sure we initialize
ddcommon::connector::Connector::default();inMINITalready, so thatrustls_native_certs::load_native_certs()callsenv::var()forSSL_CERT_FILEandSSL_CERT_DIRwhile still single threaded. This fixes a very rare crash we have seen when the uploading thread is doing it's first upload while the main thread (or any other thread) manipulates the environment variables for this process.Reviewer checklist
PROF-12605