Skip to content

refactor(prof): permanently enable allocation, exception, and timeline features#3431

Merged
realFlowControl merged 2 commits into
masterfrom
PROF-12599-Remove-compile-time-feature-flags-for-Allocation-Exception-and-Timeline
Sep 25, 2025
Merged

refactor(prof): permanently enable allocation, exception, and timeline features#3431
realFlowControl merged 2 commits into
masterfrom
PROF-12599-Remove-compile-time-feature-flags-for-Allocation-Exception-and-Timeline

Conversation

@morrisonlevi

@morrisonlevi morrisonlevi commented Sep 23, 2025 •
edited
Loading

Copy link
Copy Markdown
Collaborator

Description

  • Permanently enable allocation, exception, and timeline profiling at compile-time, and remove their feature flags and conditional compilation.
    • Retain runtime configuration checks for these features; this is a conditional compilation change only.
  • Fix related dead code/lints. Also fixes some quick but unrelated clippy lints.
  • Keep featue io_profiling feature, which is Linux-only.

This isn't a breaking change for anyone using Datadog provided profilers as these features were enabled by default before, but this may be a breaking change if anyone is building from source and is messing with features.

Reviewer checklist

  • Test coverage seems ok.
  • Appropriate labels assigned.

@morrisonlevi
refactor(prof)!: remove most compile-time feature flags
dda4f17 
- Permanently enable allocation, exception, and timeline profiling at compile-time.
- Retain runtime configuration gates for these features.
- Remove cfg(feature = "...") usage and related dead code/lints.
- Keep the Linux-only `io_profiling` feature.
@morrisonlevi
style(prof): fix clippy lints
58ad274
@morrisonlevi morrisonlevi added the profiling Relates to the Continuous Profiler label Sep 23, 2025
@codecov-commenter

codecov-commenter commented Sep 23, 2025 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 61.74%. Comparing base (f32784c) to head (58ad274).
⚠️ Report is 401 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3431      +/-   ##
==========================================
- Coverage   61.87%   61.74%   -0.14%     
==========================================
  Files         141      141              
  Lines       12481    12481              
  Branches     1630     1630              
==========================================
- Hits         7723     7706      -17     
- Misses       4038     4054      +16     
- Partials      720      721       +1

see 4 files with indirect coverage changes

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f32784c...58ad274. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@pr-commenter

pr-commenter Bot commented Sep 23, 2025

Copy link
Copy Markdown

Benchmarks [ profiler ]

Benchmark execution time: 2025-09-23 19:44:44

Comparing candidate commit 58ad274 in PR branch PROF-12599-Remove-compile-time-feature-flags-for-Allocation-Exception-and-Timeline with baseline commit f32784c in branch master.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 28 metrics, 8 unstable metrics.

@morrisonlevi
morrisonlevi marked this pull request as ready for review September 23, 2025 19:50
@morrisonlevi
morrisonlevi requested a review from a team as a code owner September 23, 2025 19:50
@realFlowControl
realFlowControl merged commit 8c81986 into master Sep 25, 2025
1869 of 1872 checks passed
@realFlowControl
realFlowControl deleted the PROF-12599-Remove-compile-time-feature-flags-for-Allocation-Exception-and-Timeline branch September 25, 2025 10:02
@github-actions github-actions Bot added this to the 1.13.0 milestone Sep 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@realFlowControl realFlowControl realFlowControl approved these changes

Assignees

No one assigned

Labels

profiling Relates to the Continuous Profiler

Projects

None yet

Milestone

1.13.0

Development

Successfully merging this pull request may close these issues.

3 participants

@morrisonlevi @codecov-commenter @realFlowControl