refactor(prof): tag handling#3423
Merged
Merged
Conversation
Tags are divided into three groups:
1. Globals which are language, profiler version, process ID, etc.
2. Unified service tags which are service, env, and version.
3. Locals, which are request-local tags where DD_TAGS are stored.
Unified service tag are also request-local but stored separately.
Globals are initialized lazily. This moves more tags into global.
The `Vec<Tag>` now reserves exactly how much memory it needs. I don't
expect this to be a meaningful change, just doing it while I'm here.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #3423 +/- ##
==========================================
- Coverage 61.87% 61.85% -0.02%
==========================================
Files 141 141
Lines 12481 12481
Branches 1630 1630
==========================================
- Hits 7722 7720 -2
- Misses 4038 4041 +3
+ Partials 721 720 -1 see 1 file with indirect coverage changes Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
Benchmarks [ profiler ]Benchmark execution time: 2025-09-19 21:48:24 Comparing candidate commit e653e1f in PR branch Found 0 performance improvements and 2 performance regressions! Performance is the same for 26 metrics, 8 unstable metrics. scenario:walk_stack/50
scenario:walk_stack/99
|
morrisonlevi
marked this pull request as ready for review
September 19, 2025 22:14
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Tags are now divided into three groups:
Globals are initialized lazily. This moves more tags into global.
The warning for an invalid tag now includes the key name. All our tag keys are static, so there's not privacy concern to include it.
The
Vec<Tag>now reserves exactly how much memory it needs. I don't expect this to be a meaningful performance change, just doing it while I'm here.Reviewer checklist