Skip to content

Fix a couple memory leaks#3420

Merged
bwoebi merged 3 commits into
masterfrom
bob/stuff
Sep 22, 2025
Merged

Fix a couple memory leaks#3420
bwoebi merged 3 commits into
masterfrom
bob/stuff

Conversation

@bwoebi

@bwoebi bwoebi commented Sep 19, 2025

Copy link
Copy Markdown
Collaborator
  • HTTP stream doesn't free its temporary context
  • Mapped peer service name is not freed.
  • Null check for ExecIntegration

@bwoebi
bwoebi requested review from a team as code owners September 19, 2025 14:23
@codecov-commenter

codecov-commenter commented Sep 19, 2025

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 61.85%. Comparing base (4c233be) to head (491deca).
⚠️ Report is 3 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3420      +/-   ##
==========================================
- Coverage   61.87%   61.85%   -0.02%     
==========================================
  Files         141      141              
  Lines       12481    12481              
  Branches     1630     1630              
==========================================
- Hits         7722     7720       -2     
- Misses       4038     4041       +3     
+ Partials      721      720       -1     

see 1 file with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4c233be...491deca. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@pr-commenter

pr-commenter Bot commented Sep 19, 2025

Copy link
Copy Markdown

Benchmarks [ tracer ]

Benchmark execution time: 2025-09-19 15:26:14

Comparing candidate commit 4bd5a3d in PR branch bob/stuff with baseline commit 4c233be in branch master.

Found 3 performance improvements and 4 performance regressions! Performance is the same for 186 metrics, 1 unstable metrics.

scenario:MessagePackSerializationBench/benchMessagePackSerialization

  • 🟩 execution_time [-4.483µs; -3.397µs] or [-4.183%; -3.169%]

scenario:MessagePackSerializationBench/benchMessagePackSerialization-opcache

  • 🟩 execution_time [-8.534µs; -7.026µs] or [-7.417%; -6.106%]

scenario:SamplingRuleMatchingBench/benchRegexMatching1

  • 🟥 execution_time [+75.057ns; +137.943ns] or [+6.344%; +11.659%]

scenario:SamplingRuleMatchingBench/benchRegexMatching2

  • 🟥 execution_time [+34.761ns; +121.639ns] or [+2.876%; +10.064%]

scenario:SamplingRuleMatchingBench/benchRegexMatching3

  • 🟥 execution_time [+80.715ns; +147.285ns] or [+6.852%; +12.503%]

scenario:SamplingRuleMatchingBench/benchRegexMatching4

  • 🟥 execution_time [+94.500ns; +144.500ns] or [+8.112%; +12.405%]

scenario:TraceSerializationBench/benchSerializeTrace

  • 🟩 execution_time [-43.154µs; -30.346µs] or [-9.730%; -6.842%]

@bwoebi
bwoebi merged commit 4fb6495 into master Sep 22, 2025
1846 of 1870 checks passed
@bwoebi
bwoebi deleted the bob/stuff branch September 22, 2025 14:23
@github-actions github-actions Bot added this to the 1.13.0 milestone Sep 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants