Support curl_multi_exec root spans#3419
Merged
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #3419 +/- ##
==========================================
- Coverage 61.87% 61.77% -0.10%
==========================================
Files 141 141
Lines 12481 12481
Branches 1630 1630
==========================================
- Hits 7722 7710 -12
- Misses 4038 4051 +13
+ Partials 721 720 -1 see 4 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
Benchmarks [ tracer ]Benchmark execution time: 2025-09-22 15:23:23 Comparing candidate commit d4edc09 in PR branch Found 5 performance improvements and 7 performance regressions! Performance is the same for 181 metrics, 1 unstable metrics. scenario:BM_TeaSapiSpindown
scenario:ComposerTelemetryBench/benchTelemetryParsing-opcache
scenario:EmptyFileBench/benchEmptyFileDdprof-opcache
scenario:MessagePackSerializationBench/benchMessagePackSerialization
scenario:MessagePackSerializationBench/benchMessagePackSerialization-opcache
scenario:SamplingRuleMatchingBench/benchRegexMatching1
scenario:SamplingRuleMatchingBench/benchRegexMatching2
scenario:SamplingRuleMatchingBench/benchRegexMatching3
scenario:SamplingRuleMatchingBench/benchRegexMatching4
scenario:SymfonyBench/benchSymfonyDdprof-opcache
scenario:TraceAnnotationsBench/benchTraceAnnotationOverhead-opcache
scenario:TraceSerializationBench/benchSerializeTrace
|
bwoebi
force-pushed
the
bob/root-multi-curl
branch
from
September 19, 2025 12:42
9555c72 to
f8988cb
Compare
Instead of updating the duration of the first invocation, close the span upon the final invocation.
bwoebi
force-pushed
the
bob/root-multi-curl
branch
from
September 19, 2025 14:16
f8988cb to
3d74ec2
Compare
bwoebi
force-pushed
the
bob/root-multi-curl
branch
from
September 22, 2025 14:17
3d74ec2 to
d4edc09
Compare
Leiyks
reviewed
Sep 25, 2025
Leiyks
approved these changes
Sep 25, 2025
| $span->meta[Tag::COMPONENT] = self::NAME; | ||
| $span->peerServiceSources = HttpClientIntegrationHelper::PEER_SERVICE_SOURCES; | ||
|
|
||
| \DDTrace\collect_code_origins(1); |
Collaborator
There was a problem hiding this comment.
Code origins weren't enabled for this span before, right? Should we call this out in the title/description?
Collaborator
Author
There was a problem hiding this comment.
They were. Code origins are enabled for spans started via $hook->span(), but not start_span(), so we need to do it manually.
Co-authored-by: Alexandre Rulleau <[email protected]>
github-actions
Bot
added
profiling
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Instead of updating the duration of the first invocation, close the span upon the final invocation.