Reduce integrations overhead#3380
Conversation
a4e63a4 to
66951c5
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #3380 +/- ##
==========================================
- Coverage 61.87% 61.74% -0.13%
==========================================
Files 141 141
Lines 12481 12481
Branches 1630 1630
==========================================
- Hits 7722 7706 -16
- Misses 4038 4054 +16
Partials 721 721 see 3 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
Benchmarks [ tracer ]Benchmark execution time: 2025-09-18 17:45:37 Comparing candidate commit a78c4ee in PR branch Found 11 performance improvements and 2 performance regressions! Performance is the same for 181 metrics, 0 unstable metrics. scenario:ComposerTelemetryBench/benchTelemetryParsing-opcache
scenario:ContextPropagationBench/benchExtractHeaders64Bit
scenario:HookBench/benchHookOverheadInstallHookOnFunction
scenario:HookBench/benchHookOverheadInstallHookOnFunction-opcache
scenario:HookBench/benchHookOverheadInstallHookOnMethod
scenario:HookBench/benchHookOverheadInstallHookOnMethod-opcache
scenario:LogsInjectionBench/benchLogsInfoInjection
scenario:LogsInjectionBench/benchLogsInfoInjection-opcache
scenario:MessagePackSerializationBench/benchMessagePackSerialization
scenario:MessagePackSerializationBench/benchMessagePackSerialization-opcache
scenario:PHPRedisBench/benchRedisOverhead
scenario:PHPRedisBench/benchRedisOverhead-opcache
scenario:TraceSerializationBench/benchSerializeTrace
|
b5df6e7 to
c81d074
Compare
Benchmarks [ profiler ]Benchmark execution time: 2025-09-18 16:54:28 Comparing candidate commit a78c4ee in PR branch Found 0 performance improvements and 0 performance regressions! Performance is the same for 28 metrics, 8 unstable metrics. |
6005add to
350c05d
Compare
229d1fa to
908d13c
Compare
ac3d79c to
eb180fb
Compare
Signed-off-by: Bob Weinand <[email protected]> # Conflicts: # src/DDTrace/Integrations/Kafka/KafkaIntegration.php
(^[\t ]++)(.*)(?<!static |_)\b(function\s*\(([^$\n]++|\n|\$(?!this))+?^\1}) by $1$2static $3
Signed-off-by: Bob Weinand <[email protected]>
Signed-off-by: Bob Weinand <[email protected]>
Signed-off-by: Bob Weinand <[email protected]>
eb180fb to
4f9acaf
Compare
Signed-off-by: Bob Weinand <[email protected]>
|
Hey @bwoebi! I did not investigate too much, but I think this PR is a cause of a change in behaviour in hooks using static methods. We are using <?php
final class Instrumentation
{
public static function commandExecutors(): void
{
install_hook(
CommandExecutor::class.'::execute',
static function (HookData $hook): void {
$span = $hook->span();
// ...
$span->meta['command_executor.class'] = self::class;
// ...
},
);
}
}Previously Is this expected? |
|
@marmichalski Yes, that behaviour is now expected, if you want to use |
Uh oh!
There was an error while loading. Please reload this page.