Skip to content

Enable the sidecar sender by default on AWS lambda#3147

Merged
bwoebi merged 1 commit intomasterfrom
bob/default-sidecar-lambda
Mar 28, 2025
Merged

Enable the sidecar sender by default on AWS lambda#3147
bwoebi merged 1 commit intomasterfrom
bob/default-sidecar-lambda

Conversation

@bwoebi
Copy link
Copy Markdown
Collaborator

@bwoebi bwoebi commented Mar 27, 2025

See comment in diff :-)

@bwoebi bwoebi requested a review from a team as a code owner March 27, 2025 20:10
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Mar 27, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 56.98%. Comparing base (342ff32) to head (b70fe79).
⚠️ Report is 761 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #3147   +/-   ##
=========================================
  Coverage     56.97%   56.98%           
  Complexity     2883     2883           
=========================================
  Files           141      141           
  Lines         15846    15844    -2     
  Branches       1095     1094    -1     
=========================================
  Hits           9028     9028           
+ Misses         6244     6243    -1     
+ Partials        574      573    -1     
Flag Coverage Δ
appsec-extension 69.22% <ø> (+0.03%) ⬆️
tracer-php 52.26% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
appsec/src/extension/configuration.c 62.62% <ø> (+1.24%) ⬆️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 342ff32...b70fe79. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@pr-commenter
Copy link
Copy Markdown

pr-commenter Bot commented Mar 27, 2025

Benchmarks [ tracer ]

Benchmark execution time: 2025-03-28 13:56:21

Comparing candidate commit b70fe79 in PR branch bob/default-sidecar-lambda with baseline commit 342ff32 in branch master.

Found 6 performance improvements and 2 performance regressions! Performance is the same for 170 metrics, 0 unstable metrics.

scenario:EmptyFileBench/benchEmptyFileBaseline-opcache

  • 🟩 execution_time [-220.817µs; -82.503µs] or [-6.925%; -2.587%]

scenario:EmptyFileBench/benchEmptyFileOverhead

  • 🟩 execution_time [-219.369µs; -98.591µs] or [-6.250%; -2.809%]

scenario:EmptyFileBench/benchEmptyFileOverhead-opcache

  • 🟩 execution_time [-258.718µs; -88.842µs] or [-7.166%; -2.461%]

scenario:MessagePackSerializationBench/benchMessagePackSerialization

  • 🟩 execution_time [-9.725µs; -8.915µs] or [-4.376%; -4.012%]

scenario:MessagePackSerializationBench/benchMessagePackSerialization-opcache

  • 🟩 execution_time [-10.972µs; -8.948µs] or [-4.947%; -4.034%]

scenario:PDOBench/benchPDOBaseline

  • 🟥 execution_time [+14.513µs; +15.952µs] or [+7.779%; +8.551%]

scenario:PDOBench/benchPDOBaseline-opcache

  • 🟩 execution_time [-14.754µs; -9.067µs] or [-7.387%; -4.540%]

scenario:TraceFlushBench/benchFlushTrace

  • 🟥 execution_time [+1000.000ns; +1000.000ns] or [+100.000%; +100.000%]

Comment thread ext/configuration.c
Comment thread ext/configuration.c Outdated
@bwoebi bwoebi force-pushed the bob/default-sidecar-lambda branch from 1031e51 to b70fe79 Compare March 28, 2025 13:26
@bwoebi bwoebi requested a review from a team as a code owner March 28, 2025 13:26
@bwoebi bwoebi enabled auto-merge (squash) March 28, 2025 13:44
@pr-commenter
Copy link
Copy Markdown

pr-commenter Bot commented Mar 28, 2025

Benchmarks [ appsec ]

Benchmark execution time: 2025-03-28 14:02:45

Comparing candidate commit b70fe79 in PR branch bob/default-sidecar-lambda with baseline commit 342ff32 in branch master.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 0 unstable metrics.

@bwoebi bwoebi merged commit ca48d25 into master Mar 28, 2025
690 of 757 checks passed
@bwoebi bwoebi deleted the bob/default-sidecar-lambda branch March 28, 2025 14:15
@github-actions github-actions Bot added this to the 1.8.0 milestone Mar 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants