Skip to content

fix(profiling) upscaling of I/O profiles#3146

Merged
realFlowControl merged 8 commits intomasterfrom
florian/io-prof
Mar 28, 2025
Merged

fix(profiling) upscaling of I/O profiles#3146
realFlowControl merged 8 commits intomasterfrom
florian/io-prof

Conversation

@realFlowControl
Copy link
Copy Markdown
Member

@realFlowControl realFlowControl commented Mar 27, 2025 •
edited
Loading

Description

I thought I was clever with the upscaling, but turns out that I can't bend the rules as far as I did and still have correctly upscaled numbers. So back to how poisson upscaling actually works and tada, numbers are looking good again.

Also this adds hooking into recvfrom() libc function calls.

PROF-11288

Reviewer checklist

  • Test coverage seems ok.
  • Appropriate labels assigned.

@github-actions github-actions Bot added profiling Relates to the Continuous Profiler tracing labels Mar 27, 2025
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Mar 27, 2025 •
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 52.26%. Comparing base (ca48d25) to head (d1c5443).
⚠️ Report is 761 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #3146      +/-   ##
============================================
- Coverage     56.98%   52.26%   -4.72%     
  Complexity     2883     2883              
============================================
  Files           141      114      -27     
  Lines         15844    11438    -4406     
  Branches       1094        0    -1094     
============================================
- Hits           9028     5978    -3050     
+ Misses         6243     5460     -783     
+ Partials        573        0     -573
Flag Coverage Δ
appsec-extension ?
tracer-php 52.26% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.
see 27 files with indirect coverage changes

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ca48d25...d1c5443. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@pr-commenter
Copy link
Copy Markdown

pr-commenter Bot commented Mar 27, 2025 •
edited
Loading

Benchmarks [ profiler ]

Benchmark execution time: 2025-03-28 16:47:23

Comparing candidate commit d1c5443 in PR branch florian/io-prof with baseline commit ca48d25 in branch master.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 29 metrics, 7 unstable metrics.

@realFlowControl realFlowControl added this to the 1.7.4 milestone Mar 27, 2025
@realFlowControl realFlowControl marked this pull request as ready for review March 27, 2025 20:51
@realFlowControl realFlowControl requested a review from a team as a code owner March 27, 2025 20:51
realFlowControl
realFlowControl commented Mar 27, 2025
View reviewed changes
Comment thread profiling/src/profiling/mod.rs Outdated
realFlowControl
realFlowControl commented Mar 27, 2025
View reviewed changes
Comment thread profiling/src/profiling/mod.rs Outdated
@github-actions github-actions Bot removed this from the 1.7.4 milestone Mar 28, 2025
@bwoebi
Copy link
Copy Markdown
Collaborator

bwoebi commented Mar 28, 2025

Why are we hooking into readv()? At least a quick source search for readv finds nothing in php-src.

bwoebi
bwoebi reviewed Mar 28, 2025
View reviewed changes
Comment thread profiling/src/profiling/mod.rs
bwoebi
bwoebi reviewed Mar 28, 2025
View reviewed changes
Comment thread profiling/src/profiling/mod.rs Outdated
bwoebi
bwoebi approved these changes Mar 28, 2025
View reviewed changes
Copy link
Copy Markdown
Collaborator

@bwoebi bwoebi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the readability refactor :-)

@realFlowControl realFlowControl merged commit 760d4a6 into master Mar 28, 2025
735 of 751 checks passed
@realFlowControl realFlowControl deleted the florian/io-prof branch March 28, 2025 19:01
@github-actions github-actions Bot added this to the 1.8.0 milestone Mar 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@morrisonlevi morrisonlevi morrisonlevi approved these changes

@bwoebi bwoebi bwoebi approved these changes

Assignees

No one assigned

Labels

profiling Relates to the Continuous Profiler tracing

Projects

None yet

Milestone

1.8.0

Development

Successfully merging this pull request may close these issues.

4 participants

@realFlowControl @codecov-commenter @bwoebi @morrisonlevi