Skip to content

Upgrade libddwaf#3126

Merged
cataphract merged 7 commits intomasterfrom
glopes/libddwaf-upd
Mar 27, 2025
Merged

Upgrade libddwaf#3126
cataphract merged 7 commits intomasterfrom
glopes/libddwaf-upd

Conversation

@cataphract
Copy link
Copy Markdown
Contributor

@cataphract cataphract commented Mar 12, 2025

Description

Reviewer checklist

  • Test coverage seems ok.
  • Appropriate labels assigned.

@cataphract cataphract force-pushed the glopes/libddwaf-upd branch from b9e9d5b to 968b660 Compare March 12, 2025 01:23
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Mar 12, 2025 •
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 56.66%. Comparing base (306ae92) to head (8ae6b14).
⚠️ Report is 774 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #3126   +/-   ##
=========================================
  Coverage     56.66%   56.66%           
  Complexity     2807     2807           
=========================================
  Files           140      140           
  Lines         15540    15540           
  Branches       1095     1095           
=========================================
  Hits           8805     8805           
  Misses         6161     6161           
  Partials        574      574
Flag Coverage Δ
appsec-extension 69.19% <ø> (ø)
tracer-php 51.69% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 306ae92...8ae6b14. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@pr-commenter
Copy link
Copy Markdown

pr-commenter Bot commented Mar 12, 2025 •
edited
Loading

Benchmarks [ appsec ]

Benchmark execution time: 2025-03-25 19:29:25

Comparing candidate commit 817aef6 in PR branch glopes/libddwaf-upd with baseline commit 10e685e in branch master.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 0 unstable metrics.

@cataphract cataphract force-pushed the glopes/libddwaf-upd branch 2 times, most recently from e07cd02 to a5e671e Compare March 13, 2025 09:50
@cataphract cataphract changed the base branch from master to glopes/sampler March 13, 2025 09:50
@cataphract cataphract marked this pull request as ready for review March 13, 2025 09:51
@cataphract cataphract requested review from a team as code owners March 13, 2025 09:51
@cataphract cataphract requested a review from a team as a code owner March 13, 2025 10:07
@pr-commenter
Copy link
Copy Markdown

pr-commenter Bot commented Mar 13, 2025 •
edited
Loading

Benchmarks [ tracer ]

Benchmark execution time: 2025-03-13 12:18:33

Comparing candidate commit a085c4b in PR branch glopes/libddwaf-upd with baseline commit 10e685e in branch glopes/sampler.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 178 metrics, 0 unstable metrics.

@cataphract
Upgrade libddwaf
4b51dd6 
	modified:   appsec/tests/helper/tel_subm_mock.hpp
@cataphract cataphract force-pushed the glopes/libddwaf-upd branch from a5e671e to a085c4b Compare March 13, 2025 11:50
Base automatically changed from glopes/sampler to master March 13, 2025 14:58
@cataphract cataphract force-pushed the glopes/libddwaf-upd branch 2 times, most recently from 17aba5f to a0a5c37 Compare March 20, 2025 10:55
@cataphract cataphract force-pushed the glopes/libddwaf-upd branch from a0a5c37 to 411ae04 Compare March 20, 2025 11:25
Anilm3
Anilm3 approved these changes Mar 21, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@Anilm3 Anilm3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Many small changes, but looks good to me... as far as I can tell.

Some integration tests seem to be failing but I didn't look into whether that's related...

Comment thread appsec/src/helper/subscriber/waf.cpp

namespace {
class waf_builder {
static constexpr auto BUNDLED_KEY = "datadog/0/ASM_DD/0/bundled"sv;
Copy link
Copy Markdown
Contributor

@Anilm3 Anilm3 Mar 21, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Interestingly... ASM_DD configs usually start with employee.

Comment thread appsec/src/helper/subscriber/waf.cpp Outdated
Comment thread appsec/src/helper/subscriber/waf.cpp Outdated
&these_diags);
diagnostics.merge(std::move(these_diags));
if (res) {
SPDLOG_DEBUG("Added config: {}", key.full_key());
Copy link
Copy Markdown
Contributor

@Anilm3 Anilm3 Mar 21, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: the log statement isn't accurate as it might be an update, albeit we don't know here.

@cataphract cataphract force-pushed the glopes/libddwaf-upd branch from 1006847 to 527a36e Compare March 26, 2025 23:10
@cataphract cataphract merged commit 342ff32 into master Mar 27, 2025
748 of 770 checks passed
@cataphract cataphract deleted the glopes/libddwaf-upd branch March 27, 2025 12:03
@github-actions github-actions Bot added this to the 1.8.0 milestone Mar 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Anilm3 Anilm3 Anilm3 approved these changes

Assignees

No one assigned

Labels

area:asm

Projects

None yet

Milestone

1.8.0

Development

Successfully merging this pull request may close these issues.

3 participants

@cataphract @codecov-commenter @Anilm3