Skip to content

fix(internal) EOL in VERSION file#3024

Closed
realFlowControl wants to merge 1 commit intomasterfrom
florian/fix-eol
Closed

fix(internal) EOL in VERSION file#3024
realFlowControl wants to merge 1 commit intomasterfrom
florian/fix-eol

Conversation

@realFlowControl
Copy link
Copy Markdown
Member

@realFlowControl realFlowControl commented Jan 9, 2025

Description

While creating the 1.6.0 release I learned that the VERSION file should not have an EOL 😉

Reviewer checklist

  • Test coverage seems ok.
  • Appropriate labels assigned.

@realFlowControl realFlowControl requested review from a team as code owners January 9, 2025 09:33
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Jan 9, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.80%. Comparing base (53d0aa2) to head (37f3836).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #3024   +/-   ##
=========================================
  Coverage     74.80%   74.80%           
  Complexity     2781     2781           
=========================================
  Files           112      112           
  Lines         11017    11017           
=========================================
  Hits           8241     8241           
  Misses         2776     2776
Flag Coverage Δ
tracer-php 74.80% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 53d0aa2...37f3836. Read the comment docs.

@bwoebi
Copy link
Copy Markdown
Collaborator

bwoebi commented Jan 9, 2025

What code is sensitive to the EOL not being there? Can we relax the code instead?

@realFlowControl
Copy link
Copy Markdown
Member Author

realFlowControl commented Jan 9, 2025 •
edited
Loading

@Anilm3 maybe you could have a look and relax this instead of merging this PR: https://app.circleci.com/pipelines/github/DataDog/dd-trace-php/18844/workflows/73e9d4a8-47da-4fce-85ab-1c9c8e06ca64/jobs/5885772

CMake Error at CMakeLists.txt:29 (project):
  VERSION "1.6.0

  " format invalid.

dd-trace-php/appsec/CMakeLists.txt

Line 29 in 53d0aa2

project(ddappsec VERSION ${appsec_short_version})

@Anilm3
Copy link
Copy Markdown
Contributor

Anilm3 commented Jan 9, 2025 •
edited
Loading

@Anilm3 maybe you could have a look and relax this instead of merging this PR: https://app.circleci.com/pipelines/github/DataDog/dd-trace-php/18844/workflows/73e9d4a8-47da-4fce-85ab-1c9c8e06ca64/jobs/5885772

CMake Error at CMakeLists.txt:29 (project):
  VERSION "1.6.0

  " format invalid.

dd-trace-php/appsec/CMakeLists.txt

Line 29 in 53d0aa2

project(ddappsec VERSION ${appsec_short_version})

Sure, I'll push the change to a new branch.

@Anilm3 Anilm3 mentioned this pull request Jan 9, 2025
Merged
2 tasks
@realFlowControl realFlowControl deleted the florian/fix-eol branch January 9, 2025 13:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Anilm3 Anilm3 Anilm3 approved these changes

@iamluc iamluc iamluc approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@realFlowControl @codecov-commenter @bwoebi @Anilm3 @iamluc