Skip to content

build(profiling): bump to Rust 1.76#2876

Merged
bwoebi merged 2 commits intomasterfrom
levi/prof-rust-1.76
Oct 14, 2024
Merged

build(profiling): bump to Rust 1.76#2876
bwoebi merged 2 commits intomasterfrom
levi/prof-rust-1.76

Conversation

@morrisonlevi
Copy link
Copy Markdown
Collaborator

@morrisonlevi morrisonlevi commented Oct 4, 2024 •
edited
Loading

Description

Bumps the profiler to Rust 1.76 from 1.71. The CI images were previously bumped to Rust 1.76 because of a miscompilation issue.

Reviewer checklist

  • Test coverage seems ok.
  • Appropriate labels assigned.

@morrisonlevi
build(profiling): bump to Rust 1.76
273ff03 
The CI images were previously bumped to Rust 1.76.
@morrisonlevi morrisonlevi requested a review from a team as a code owner October 4, 2024 15:19
@github-actions github-actions Bot added the profiling Relates to the Continuous Profiler label Oct 4, 2024
realFlowControl
realFlowControl approved these changes Oct 4, 2024
View reviewed changes
Copy link
Copy Markdown
Member

@realFlowControl realFlowControl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Oct 4, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.91%. Comparing base (b23438e) to head (40a8587).

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #2876      +/-   ##
============================================
+ Coverage     78.23%   80.91%   +2.68%     
  Complexity     2526     2526              
============================================
  Files           173      146      -27     
  Lines         18742    14711    -4031     
  Branches        981        0     -981     
============================================
- Hits          14662    11903    -2759     
+ Misses         3540     2808     -732     
+ Partials        540        0     -540
Flag Coverage Δ
appsec-extension ?
tracer-extension 78.10% <ø> (ø)
tracer-php 82.09% <ø> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 28 files with indirect coverage changes

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b23438e...40a8587. Read the comment docs.

@pr-commenter
Copy link
Copy Markdown

pr-commenter Bot commented Oct 4, 2024 •
edited
Loading

Benchmarks [ profiler ]

Benchmark execution time: 2024-10-10 12:00:04

Comparing candidate commit 40a8587 in PR branch levi/prof-rust-1.76 with baseline commit b23438e in branch master.

Found 5 performance improvements and 0 performance regressions! Performance is the same for 22 metrics, 9 unstable metrics.

scenario:walk_stack/50

  • 🟩 wall_time [-668.543ns; -665.759ns] or [-4.394%; -4.376%]

scenario:walk_stack/99

  • 🟩 wall_time [-641.071ns; -638.519ns] or [-4.233%; -4.216%]

scenario:walk_stack_instructions/1

  • 🟩 instructions [-2.6K instructions; -2.6K instructions] or [-2.515%; -2.511%]

scenario:walk_stack_instructions/50

  • 🟩 instructions [-2.7K instructions; -2.7K instructions] or [-2.554%; -2.551%]

scenario:walk_stack_instructions/99

  • 🟩 instructions [-2.7K instructions; -2.7K instructions] or [-2.554%; -2.551%]

@remicollet remicollet mentioned this pull request Oct 9, 2024
Closed
@remicollet
Copy link
Copy Markdown
Contributor

remicollet commented Oct 9, 2024

Looks like this break build on RHEL and clones (rust 1.75) see #2882

r1viollet
r1viollet approved these changes Oct 9, 2024
View reviewed changes
Copy link
Copy Markdown
Collaborator

@r1viollet r1viollet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bwoebi bwoebi merged commit f44e093 into master Oct 14, 2024
@bwoebi bwoebi deleted the levi/prof-rust-1.76 branch October 14, 2024 02:13
@github-actions github-actions Bot added this to the 1.5.0 milestone Oct 14, 2024
@bwoebi bwoebi modified the milestones: 1.5.0, 1.4.1 Oct 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bwoebi bwoebi bwoebi approved these changes

@realFlowControl realFlowControl realFlowControl approved these changes

@r1viollet r1viollet r1viollet approved these changes

Assignees

No one assigned

Labels

profiling Relates to the Continuous Profiler

Projects

None yet

Milestone

1.4.1

Development

Successfully merging this pull request may close these issues.

6 participants

@morrisonlevi @codecov-commenter @remicollet @bwoebi @realFlowControl @r1viollet