Fix memory leak with sidecar trace sender#2875
Merged
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2875 +/- ##
=========================================
Coverage 80.91% 80.91%
Complexity 2526 2526
=========================================
Files 146 146
Lines 14711 14711
=========================================
Hits 11903 11903
Misses 2808 2808
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report in Codecov by Sentry.
|
bwoebi
force-pushed
the
bob/ffi_try_sync_flush
branch
from
cbe032b to
19d324a
Compare
Benchmarks [ tracer ]Benchmark execution time: 2024-10-04 17:06:05 Comparing candidate commit b9fa0f0 in PR branch Found 2 performance improvements and 3 performance regressions! Performance is the same for 173 metrics, 0 unstable metrics. scenario:MessagePackSerializationBench/benchMessagePackSerialization
scenario:MessagePackSerializationBench/benchMessagePackSerialization-opcache
scenario:PDOBench/benchPDOBaseline
scenario:PDOBench/benchPDOBaseline-opcache
scenario:SamplingRuleMatchingBench/benchRegexMatching3
|
bwoebi
force-pushed
the
bob/ffi_try_sync_flush
branch
from
19d324a to
480078a
Compare
iamluc
approved these changes
Oct 4, 2024
bwoebi
force-pushed
the
bob/ffi_try_sync_flush
branch
2 times, most recently
from
0d94b95 to
b9fa0f0
Compare
bwoebi
force-pushed
the
bob/ffi_try_sync_flush
branch
from
b9fa0f0 to
a2ef23e
Compare
And set LSAN_OPTIONS=fast_unwind_on_malloc=0 for more complete traces
bwoebi
force-pushed
the
bob/ffi_try_sync_flush
branch
from
a2ef23e to
9387bec
Compare
github-actions
Bot
added
profiling
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
And set LSAN_OPTIONS=fast_unwind_on_malloc=0 for more complete traces.