Skip to content

fix(mongodb): Deprecated exception in v1.20+#2870

Merged
PROFeNoM merged 1 commit intomasterfrom
alex/fix/GH-2869
Oct 4, 2024
Merged

fix(mongodb): Deprecated exception in v1.20+#2870
PROFeNoM merged 1 commit intomasterfrom
alex/fix/GH-2869

Conversation

@PROFeNoM
Copy link
Copy Markdown
Contributor

@PROFeNoM PROFeNoM commented Oct 2, 2024 •
edited
Loading

Description

Fix #2869
Fix #2873

  • First CI run before updating the buster containers passed
  • Update the buster containers
  • Second CI after updating the buster containers passed

Reviewer checklist

  • Test coverage seems ok.
  • Appropriate labels assigned.

@PROFeNoM PROFeNoM added 🐛 bug Something isn't working cat:integration labels Oct 2, 2024
@PROFeNoM PROFeNoM self-assigned this Oct 2, 2024
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Oct 2, 2024 •
edited
Loading

Codecov Report

❌ Patch coverage is 71.42857% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 80.91%. Comparing base (6eb87bc) to head (c8cbed1).
⚠️ Report is 546 commits behind head on master.

Files with missing lines Patch % Lines
...DTrace/Integrations/MongoDB/MongoDBIntegration.php 71.42% 2 Missing ⚠️

❌ Your patch status has failed because the patch coverage (71.42%) is below the target coverage (90.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #2870      +/-   ##
============================================
- Coverage     80.91%   80.91%   -0.01%     
  Complexity     2526     2526              
============================================
  Files           146      146              
  Lines         14706    14711       +5     
============================================
+ Hits          11900    11903       +3     
- Misses         2806     2808       +2
Flag Coverage Δ
tracer-extension 78.10% <ø> (ø)
tracer-php 82.09% <71.42%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...DTrace/Integrations/MongoDB/MongoDBIntegration.php 98.61% <71.42%> (-0.46%) ⬇️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6eb87bc...c8cbed1. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@pr-commenter
Copy link
Copy Markdown

pr-commenter Bot commented Oct 2, 2024

Benchmarks [ tracer ]

Benchmark execution time: 2024-10-02 15:35:49

Comparing candidate commit d09d87c in PR branch alex/fix/GH-2869 with baseline commit b8fde57 in branch master.

Found 1 performance improvements and 1 performance regressions! Performance is the same for 176 metrics, 0 unstable metrics.

scenario:PDOBench/benchPDOBaseline

  • 🟩 execution_time [-13.027µs; -11.532µs] or [-6.766%; -5.990%]

scenario:PDOBench/benchPDOOverheadWithDBM

  • 🟥 execution_time [+11.638µs; +13.811µs] or [+3.916%; +4.647%]

@PROFeNoM PROFeNoM force-pushed the alex/fix/GH-2869 branch 2 times, most recently from 5140557 to 85fb6ad Compare October 4, 2024 07:22
@PROFeNoM PROFeNoM marked this pull request as ready for review October 4, 2024 07:45
@PROFeNoM PROFeNoM requested a review from a team as a code owner October 4, 2024 07:45
@PROFeNoM PROFeNoM requested a review from a team October 4, 2024 07:45
@PROFeNoM PROFeNoM merged commit bb96a53 into master Oct 4, 2024
@PROFeNoM PROFeNoM deleted the alex/fix/GH-2869 branch October 4, 2024 08:27
@github-actions github-actions Bot added this to the 1.4.0 milestone Oct 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pablomartinezbernardo pablomartinezbernardo pablomartinezbernardo approved these changes

Assignees

@PROFeNoM PROFeNoM

Labels

🐛 bug Something isn't working cat:integration

Projects

None yet

Milestone

1.4.0

3 participants

@PROFeNoM @codecov-commenter @pablomartinezbernardo