Fix orderly helper appsec shutdown#2859
Merged
cataphract merged 2 commits intomasterfrom Sep 19, 2024
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #2859 +/- ##
============================================
- Coverage 80.94% 78.40% -2.55%
Complexity 2526 2526
============================================
Files 146 173 +27
Lines 14680 18709 +4029
Branches 0 975 +975
============================================
+ Hits 11883 14668 +2785
- Misses 2797 3504 +707
- Partials 0 537 +537
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
Anilm3
reviewed
Sep 17, 2024
The sent SIGUSR1 was just terminating the process.
cataphract
force-pushed
the
glopes/fix-helper-exit
branch
from
f7685aa to
6fea9c9
Compare
Anilm3
reviewed
Sep 18, 2024
Anilm3
approved these changes
Sep 18, 2024
cataphract
force-pushed
the
glopes/fix-helper-exit
branch
from
bc83e5c to
d63c6b3
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The sent SIGUSR1 was just terminating the process.
Description
Reviewer checklist