Skip to content

Add ionCube to the list of incompatible extensions + add INI setting to ignore incompatible extensions#2858

Merged
iamluc merged 5 commits intomasterfrom
luc/conflict-with-ioncube
Sep 19, 2024
Merged

Add ionCube to the list of incompatible extensions + add INI setting to ignore incompatible extensions#2858
iamluc merged 5 commits intomasterfrom
luc/conflict-with-ioncube

Conversation

@iamluc
Copy link
Copy Markdown
Contributor

@iamluc iamluc commented Sep 17, 2024

Description

Reviewer checklist

  • Test coverage seems ok.
  • Appropriate labels assigned.

@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Sep 17, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.40%. Comparing base (17b3c7a) to head (2581e73).
Report is 489 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #2858      +/-   ##
============================================
- Coverage     80.94%   78.40%   -2.55%     
  Complexity     2526     2526              
============================================
  Files           146      173      +27     
  Lines         14680    18709    +4029     
  Branches          0      975     +975     
============================================
+ Hits          11883    14668    +2785     
- Misses         2797     3504     +707     
- Partials          0      537     +537
Flag Coverage Δ
appsec-extension 69.12% <ø> (?)
tracer-extension 78.18% <ø> (ø)
tracer-php 82.10% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 27 files with indirect coverage changes

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 17b3c7a...2581e73. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

bwoebi
bwoebi reviewed Sep 17, 2024
View reviewed changes
Comment thread ext/excluded_modules.c
@pr-commenter
Copy link
Copy Markdown

pr-commenter Bot commented Sep 17, 2024 •
edited
Loading

Benchmarks [ tracer ]

Benchmark execution time: 2024-09-19 14:34:03

Comparing candidate commit 2581e73 in PR branch luc/conflict-with-ioncube with baseline commit 17b3c7a in branch master.

Found 2 performance improvements and 5 performance regressions! Performance is the same for 171 metrics, 0 unstable metrics.

scenario:BM_TeaSapiSpindown

  • 🟥 execution_time [+14.203µs; +30.302µs] or [+2.710%; +5.781%]

scenario:ContextPropagationBench/benchInject64Bit-opcache

  • 🟥 execution_time [+276.555ns; +749.445ns] or [+3.615%; +9.797%]

scenario:EmptyFileBench/benchEmptyFileBaseline

  • 🟩 execution_time [-183.100µs; -77.220µs] or [-6.302%; -2.658%]

scenario:EmptyFileBench/benchEmptyFileBaseline-opcache

  • 🟥 execution_time [+130.763µs; +246.677µs] or [+4.568%; +8.617%]

scenario:EmptyFileBench/benchEmptyFileOverhead-opcache

  • 🟥 execution_time [+117.882µs; +233.178µs] or [+3.797%; +7.511%]

scenario:LaravelBench/benchLaravelBaseline-opcache

  • 🟥 execution_time [+106.683µs; +274.277µs] or [+3.533%; +9.082%]

scenario:WordPressBench/benchWordPressOverhead

  • 🟩 execution_time [-22.024ms; -21.606ms] or [-83.252%; -81.673%]

@iamluc iamluc marked this pull request as ready for review September 17, 2024 13:28
@iamluc iamluc requested a review from a team as a code owner September 17, 2024 13:28
bwoebi
bwoebi reviewed Sep 17, 2024
View reviewed changes
Comment thread ext/excluded_modules.c Outdated
@iamluc @bwoebi
Fix access of global config
dd25a41 
Co-authored-by: Bob Weinand <[email protected]>
bwoebi
bwoebi reviewed Sep 19, 2024
View reviewed changes
Comment thread ext/configuration.h Outdated
bwoebi
bwoebi approved these changes Sep 19, 2024
View reviewed changes
Copy link
Copy Markdown
Collaborator

@bwoebi bwoebi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good with force_inject.

@iamluc @bwoebi
Fix ini_change mode
2581e73 
Co-authored-by: Bob Weinand <[email protected]>
@iamluc iamluc merged commit 3746a2f into master Sep 19, 2024
@iamluc iamluc deleted the luc/conflict-with-ioncube branch September 19, 2024 15:38
@github-actions github-actions Bot added this to the 1.4.0 milestone Sep 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bwoebi bwoebi bwoebi approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

1.4.0

Development

Successfully merging this pull request may close these issues.

3 participants

@iamluc @codecov-commenter @bwoebi