Remove gid from socket/lock path of helper#2855
Merged
cataphract merged 1 commit intomasterfrom Sep 17, 2024
Merged
Conversation
Now that we're inside sidecar, we need to have the same uniqueness characteristics of sidecar; in particular, there's one instance of sidecar per uid, but not per (uid,gid) as was the case with the helper before.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2855 +/- ##
============================================
- Coverage 81.05% 78.49% -2.57%
Complexity 2517 2517
============================================
Files 146 173 +27
Lines 14654 18682 +4028
Branches 0 975 +975
============================================
+ Hits 11878 14664 +2786
- Misses 2776 3481 +705
- Partials 0 537 +537
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 27 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
bwoebi
approved these changes
Sep 16, 2024
Collaborator
bwoebi
left a comment
bwoebi
left a comment
There was a problem hiding this comment.
Looks trivial and is going to fix the existing issue.
Anilm3
approved these changes
Sep 16, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Now that we're inside sidecar, we need to have the same uniqueness characteristics of sidecar; in particular, there's one instance of sidecar per uid, but not per (uid,gid) as was the case with the helper before.
Reviewer checklist