Fix improper symbol exports in appsec ext/helper#2854
Merged
cataphract merged 2 commits intomasterfrom Sep 16, 2024
Merged
Conversation
Both the extension and the helper need version scripts to prevent symbols from being exported. -fvisibility=hidden is not sufficient because it's not being applied to some of the static libraries they link against. On the extensions side: the path to the version script was wrong, as this error was ultimately ignored because invalid ld options were being ingored. This resulted in some extra zai_* functions being exported. On the helper side. Symbols from libunwind, libc++ and possibly others were being exported.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2854 +/- ##
============================================
- Coverage 81.05% 78.49% -2.57%
Complexity 2517 2517
============================================
Files 146 173 +27
Lines 14654 18683 +4029
Branches 0 975 +975
============================================
+ Hits 11878 14665 +2787
- Misses 2776 3481 +705
- Partials 0 537 +537
Flags with carried forward coverage won't be shown. Click here to find out more. see 28 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
bwoebi
approved these changes
Sep 16, 2024
Collaborator
bwoebi
left a comment
bwoebi
left a comment
There was a problem hiding this comment.
Works for me, thanks :-)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Both the extension and the helper need version scripts to prevent symbols from being exported. -fvisibility=hidden is not sufficient because it's not being applied to some of the static libraries they link against.
On the extensions side: the path to the version script was wrong, as this error was ultimately ignored because invalid ld options were being ingored. This resulted in some extra zai_* functions being exported.
On the helper side: symbols from libunwind, libc++ and possibly others were being exported.
Reviewer checklist