Skip to content

Fix benchmarks#2852

Merged
estringana merged 1 commit intomasterfrom
estringana/fix-benchmark
Sep 16, 2024
Merged

Fix benchmarks#2852
estringana merged 1 commit intomasterfrom
estringana/fix-benchmark

Conversation

@estringana
Copy link
Copy Markdown
Contributor

Description

Fix tea file not being found on the artefacts of the benchmarks runs

Reviewer checklist

  • Test coverage seems ok.
  • Appropriate labels assigned.

@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Sep 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.07%. Comparing base (1a7182c) to head (7beae02).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #2852   +/-   ##
=========================================
  Coverage     81.07%   81.07%           
  Complexity     2517     2517           
=========================================
  Files           146      146           
  Lines         14654    14654           
=========================================
  Hits          11880    11880           
  Misses         2774     2774           
Flag Coverage Δ
tracer-extension 78.18% <ø> (ø)
tracer-php 82.27% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1a7182c...7beae02. Read the comment docs.

@pr-commenter
Copy link
Copy Markdown

pr-commenter Bot commented Sep 16, 2024

Benchmarks [ tracer ]

Benchmark execution time: 2024-09-16 10:28:26

Comparing candidate commit 7beae02 in PR branch estringana/fix-benchmark with baseline commit 1a7182c in branch master.

Found 1 performance improvements and 1 performance regressions! Performance is the same for 176 metrics, 0 unstable metrics.

scenario:LaravelBench/benchLaravelBaseline

  • 🟥 execution_time [+105.003µs; +234.157µs] or [+3.611%; +8.053%]

scenario:WordPressBench/benchWordPressOverhead

  • 🟩 execution_time [-21.950ms; -21.665ms] or [-83.123%; -82.045%]

@estringana estringana marked this pull request as ready for review September 16, 2024 10:31
@estringana estringana requested a review from a team as a code owner September 16, 2024 10:31
@estringana estringana merged commit 31382ec into master Sep 16, 2024
@estringana estringana deleted the estringana/fix-benchmark branch September 16, 2024 10:38
@github-actions github-actions Bot added this to the 1.4.0 milestone Sep 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants