Merged
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2846 +/- ##
=========================================
Coverage 81.06% 81.06%
Complexity 2516 2516
=========================================
Files 146 146
Lines 14653 14653
=========================================
Hits 11879 11879
Misses 2774 2774
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report in Codecov by Sentry.
|
iamluc
force-pushed
the
luc/fix-composer-install-issue-predis
branch
from
d98ba95 to
c3b3514
Compare
…ckage in the same directory
iamluc
force-pushed
the
luc/fix-composer-install-issue-predis
branch
from
c3b3514 to
8f066a7
Compare
bwoebi
approved these changes
Sep 12, 2024
Collaborator
bwoebi
left a comment
bwoebi
left a comment
There was a problem hiding this comment.
Looks like my mistake, thanks for catching :-)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Both scenarios DeferredLoading and Predis were running
composer installin the same directory.It seems it could break the installation
i.e. https://app.circleci.com/pipelines/github/DataDog/dd-trace-php/17446/workflows/0a933327-d943-4704-b7c9-4f9f560cb329/jobs/5142824
Reviewer checklist