Disable trace_generator_jit.phpt test on PHP 8.0#2835
Merged
Conversation
…table enough on PHP 8.0
bwoebi
approved these changes
Sep 4, 2024
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #2835 +/- ##
============================================
+ Coverage 73.97% 81.06% +7.09%
Complexity 2516 2516
============================================
Files 173 146 -27
Lines 18680 14651 -4029
Branches 975 0 -975
============================================
- Hits 13818 11877 -1941
+ Misses 4325 2774 -1551
+ Partials 537 0 -537
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Because JIT is not stable enough on PHP 8.0.
Could be related to this fix which seems to have been applied only to PHP 8.1.15 and 8.2.2, but not to PHP 8.0.
Reviewer checklist