Skip to content

Improve tests stability#2830

Merged
iamluc merged 4 commits intomasterfrom
luc/test-stability-1
Sep 4, 2024
Merged

Improve tests stability#2830
iamluc merged 4 commits intomasterfrom
luc/test-stability-1

Conversation

@iamluc
Copy link
Copy Markdown
Contributor

@iamluc iamluc commented Sep 3, 2024

Description

Reviewer checklist

  • Test coverage seems ok.
  • Appropriate labels assigned.

@iamluc iamluc changed the title Remove flakiness from the crashtracker_segfault.phpt test Improve tests stability Sep 3, 2024
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Sep 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.49%. Comparing base (e7adb51) to head (ccb107e).

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #2830      +/-   ##
============================================
+ Coverage     75.30%   78.49%   +3.18%     
  Complexity     2516     2516              
============================================
  Files           146      173      +27     
  Lines         14651    18680    +4029     
  Branches          0      975     +975     
============================================
+ Hits          11033    14662    +3629     
+ Misses         3618     3481     -137     
- Partials          0      537     +537     
Flag Coverage Δ
appsec-extension 69.12% <ø> (?)
tracer-extension 78.17% <ø> (ø)
tracer-php 82.27% <ø> (+8.17%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 36 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e7adb51...ccb107e. Read the comment docs.

@iamluc iamluc force-pushed the luc/test-stability-1 branch 3 times, most recently from 852ba81 to 9a341fe Compare September 3, 2024 13:51
@iamluc iamluc force-pushed the luc/test-stability-1 branch from 9a341fe to a5bf3e0 Compare September 3, 2024 14:16
@iamluc iamluc marked this pull request as ready for review September 3, 2024 15:44
@iamluc iamluc requested a review from a team as a code owner September 3, 2024 15:44
Comment thread tests/ext/crashtracker_segfault.phpt Outdated
@pr-commenter
Copy link
Copy Markdown

pr-commenter Bot commented Sep 4, 2024

Benchmarks

Benchmark execution time: 2024-09-04 08:17:04

Comparing candidate commit ccb107e in PR branch luc/test-stability-1 with baseline commit e7adb51 in branch master.

Found 7 performance improvements and 1 performance regressions! Performance is the same for 170 metrics, 0 unstable metrics.

scenario:ContextPropagationBench/benchExtractHeaders128Bit-opcache

  • 🟩 execution_time [-44.318ns; -30.349ns] or [-4.210%; -2.883%]

scenario:EmptyFileBench/benchEmptyFileOverhead

  • 🟩 execution_time [-242.761µs; -110.459µs] or [-8.502%; -3.869%]

scenario:LaravelBench/benchLaravelOverhead

  • 🟩 execution_time [-218.920µs; -83.360µs] or [-7.361%; -2.803%]

scenario:PDOBench/benchPDOBaseline

  • 🟩 execution_time [-17.267µs; -15.852µs] or [-9.286%; -8.526%]

scenario:PDOBench/benchPDOOverhead

  • 🟩 execution_time [-19.440µs; -17.441µs] or [-7.072%; -6.345%]

scenario:PDOBench/benchPDOOverheadWithDBM

  • 🟩 execution_time [-17.768µs; -16.424µs] or [-5.995%; -5.541%]

scenario:SamplingRuleMatchingBench/benchRegexMatching1-opcache

  • 🟥 execution_time [+142.307ns; +495.693ns] or [+2.165%; +7.540%]

scenario:WordPressBench/benchWordPressOverhead

  • 🟩 execution_time [-21.590ms; -21.487ms] or [-83.595%; -83.196%]

Copy link
Copy Markdown
Collaborator

@bwoebi bwoebi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks :-)
Let's merge this and address the remaining ones in another PR.

@iamluc iamluc merged commit bcb0c30 into master Sep 4, 2024
@iamluc iamluc deleted the luc/test-stability-1 branch September 4, 2024 12:01
@bwoebi bwoebi added this to the 1.3.1 milestone Sep 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants