Skip to content

Make the GitLab CI workflow work when triggered by tags#2828

Merged
iamluc merged 1 commit intomasterfrom
luc/gitlab-ci-tags
Sep 2, 2024
Merged

Make the GitLab CI workflow work when triggered by tags#2828
iamluc merged 1 commit intomasterfrom
luc/gitlab-ci-tags

Conversation

@iamluc
Copy link
Copy Markdown
Contributor

@iamluc iamluc commented Sep 2, 2024

Description

Reviewer checklist

  • Test coverage seems ok.
  • Appropriate labels assigned.

@iamluc iamluc requested a review from a team as a code owner September 2, 2024 07:46
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Sep 2, 2024

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 75.34%. Comparing base (8b6e326) to head (3e30261).
⚠️ Report is 1051 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #2828      +/-   ##
============================================
+ Coverage     74.00%   75.34%   +1.34%     
  Complexity     2516     2516              
============================================
  Files           173      146      -27     
  Lines         18680    14651    -4029     
  Branches        975        0     -975     
============================================
- Hits          13824    11039    -2785     
+ Misses         4319     3612     -707     
+ Partials        537        0     -537     
Flag Coverage Δ
appsec-extension ?
tracer-extension 78.17% <ø> (ø)
tracer-php 74.16% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.
see 27 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8b6e326...3e30261. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Copy Markdown
Collaborator

@bwoebi bwoebi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks right at a glance.

@iamluc iamluc merged commit e7adb51 into master Sep 2, 2024
@iamluc iamluc deleted the luc/gitlab-ci-tags branch September 2, 2024 09:40
@bwoebi bwoebi added this to the 1.3.1 milestone Sep 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants