Skip to content

Dynamic configuration and live debugger#2796

Merged
bwoebi merged 37 commits intomasterfrom
bob/live-debugger
Oct 2, 2024
Merged

Dynamic configuration and live debugger#2796
bwoebi merged 37 commits intomasterfrom
bob/live-debugger

Conversation

@bwoebi
Copy link
Copy Markdown
Collaborator

@bwoebi bwoebi commented Aug 19, 2024

No description provided.

@bwoebi bwoebi requested review from a team as code owners August 19, 2024 13:18
@bwoebi bwoebi force-pushed the bob/live-debugger branch from d5e79fb to 0c07cd6 Compare August 29, 2024 12:34
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Aug 29, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 55.17241% with 13 lines in your changes missing coverage. Please review.

Project coverage is 80.91%. Comparing base (b8fde57) to head (2e28bde).
Report is 2 commits behind head on master.

Files with missing lines Patch % Lines
zend_abstract_interface/hook/hook.c 54.54% 10 Missing ⚠️
..._abstract_interface/interceptor/php7/interceptor.c 50.00% 2 Missing ⚠️
zend_abstract_interface/config/config.c 0.00% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #2796      +/-   ##
============================================
- Coverage     80.97%   80.91%   -0.06%     
  Complexity     2526     2526              
============================================
  Files           146      146              
  Lines         14683    14704      +21     
============================================
+ Hits          11889    11898       +9     
- Misses         2794     2806      +12
Flag Coverage Δ
tracer-extension 78.09% <55.17%> (-0.18%) ⬇️
tracer-php 82.10% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
zend_abstract_interface/config/config_ini.c 73.00% <100.00%> (ø)
zend_abstract_interface/exceptions/exceptions.c 91.80% <ø> (ø)
zend_abstract_interface/exceptions/exceptions.h 83.33% <100.00%> (ø)
zend_abstract_interface/hook/hook.h 100.00% <ø> (ø)
zend_abstract_interface/config/config.c 94.06% <0.00%> (-0.05%) ⬇️
..._abstract_interface/interceptor/php7/interceptor.c 89.56% <50.00%> (-0.26%) ⬇️
zend_abstract_interface/hook/hook.c 54.80% <54.54%> (-0.19%) ⬇️

... and 1 file with indirect coverage changes

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b8fde57...2e28bde. Read the comment docs.

@pr-commenter
Copy link
Copy Markdown

pr-commenter Bot commented Aug 29, 2024 •
edited
Loading

Benchmarks

Benchmark execution time: 2024-09-09 19:59:44

Comparing candidate commit a57fbfa in PR branch bob/live-debugger with baseline commit bcb0c30 in branch master.

Found 16 performance improvements and 7 performance regressions! Performance is the same for 155 metrics, 0 unstable metrics.

scenario:EmptyFileBench/benchEmptyFileBaseline

  • 🟩 execution_time [-621.581µs; -391.699µs] or [-19.976%; -12.588%]

scenario:EmptyFileBench/benchEmptyFileBaseline-opcache

  • 🟩 execution_time [-584.694µs; -408.426µs] or [-18.191%; -12.707%]

scenario:EmptyFileBench/benchEmptyFileOverhead

  • 🟩 execution_time [-706.689µs; -497.231µs] or [-20.268%; -14.261%]

scenario:EmptyFileBench/benchEmptyFileOverhead-opcache

  • 🟩 execution_time [-641.657µs; -436.663µs] or [-17.759%; -12.086%]

scenario:LaravelBench/benchLaravelBaseline

  • 🟩 execution_time [-407.611µs; -197.989µs] or [-13.146%; -6.386%]

scenario:LaravelBench/benchLaravelBaseline-opcache

  • 🟩 execution_time [-475.336µs; -304.164µs] or [-14.529%; -9.297%]

scenario:LaravelBench/benchLaravelOverhead

  • 🟩 execution_time [-558.756µs; -371.904µs] or [-15.816%; -10.527%]

scenario:LaravelBench/benchLaravelOverhead-opcache

  • 🟩 execution_time [-728.337µs; -519.563µs] or [-19.198%; -13.695%]

scenario:MessagePackSerializationBench/benchMessagePackSerialization-opcache

  • 🟩 execution_time [-10.218µs; -8.142µs] or [-6.764%; -5.390%]

scenario:PDOBench/benchPDOOverhead

  • 🟥 execution_time [+128.727µs; +134.061µs] or [+50.536%; +52.630%]

scenario:PDOBench/benchPDOOverhead-opcache

  • 🟥 execution_time [+121.006µs; +124.346µs] or [+44.267%; +45.489%]

scenario:PDOBench/benchPDOOverheadWithDBM

  • 🟥 execution_time [+128.483µs; +131.611µs] or [+46.327%; +47.455%]

scenario:PDOBench/benchPDOOverheadWithDBM-opcache

  • 🟥 execution_time [+126.123µs; +131.219µs] or [+41.250%; +42.917%]

scenario:PHPRedisBench/benchRedisOverhead

  • 🟥 execution_time [+194.982µs; +199.068µs] or [+80.189%; +81.870%]

scenario:PHPRedisBench/benchRedisOverhead-opcache

  • 🟥 execution_time [+190.588µs; +194.360µs] or [+69.031%; +70.397%]

scenario:SymfonyBench/benchSymfonyBaseline

  • 🟩 execution_time [-415.545µs; -364.395µs] or [-6.667%; -5.846%]

scenario:SymfonyBench/benchSymfonyBaseline-opcache

  • 🟩 execution_time [-450.131µs; -359.649µs] or [-7.053%; -5.635%]

scenario:SymfonyBench/benchSymfonyOverhead

  • 🟩 execution_time [-825.588µs; -772.572µs] or [-11.315%; -10.589%]

scenario:SymfonyBench/benchSymfonyOverhead-opcache

  • 🟩 execution_time [-830.333µs; -752.287µs] or [-11.186%; -10.135%]

scenario:TraceSerializationBench/benchSerializeTrace

  • 🟥 execution_time [+6.371µs; +11.529µs] or [+3.751%; +6.788%]

scenario:WordPressBench/benchWordPressBaseline-opcache

  • 🟩 execution_time [-605.985µs; -486.655µs] or [-2.696%; -2.165%]

scenario:WordPressBench/benchWordPressOverhead

  • 🟩 execution_time [-25.917ms; -25.814ms] or [-85.591%; -85.252%]

scenario:WordPressBench/benchWordPressOverhead-opcache

  • 🟩 execution_time [-4.359ms; -4.124ms] or [-14.315%; -13.543%]

@bwoebi bwoebi force-pushed the bob/live-debugger branch 3 times, most recently from e0df4e5 to c6abf85 Compare September 4, 2024 12:20
@bwoebi bwoebi force-pushed the bob/live-debugger branch 9 times, most recently from 60556da to c445c83 Compare September 11, 2024 13:20
@bwoebi bwoebi force-pushed the bob/live-debugger branch 5 times, most recently from 17ff043 to 64a7e9e Compare September 23, 2024 03:58
iamluc
iamluc approved these changes Sep 23, 2024
View reviewed changes
Copy link
Copy Markdown
Contributor

@iamluc iamluc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👏 Really impressive PR 😲

Comment thread tests/ext/live-debugger/debugger_metric_probe.phpt Outdated
Comment thread components-rs/remote_config.rs
Comment thread ext/remote_config.c
Comment thread ext/live_debugger.c
Comment thread ext/sidecar.c Outdated
@bwoebi bwoebi force-pushed the bob/live-debugger branch 5 times, most recently from d7f86c7 to c29b924 Compare September 27, 2024 17:10
bwoebi added 16 commits October 1, 2024 13:30
@bwoebi
Fix
03f4122 
Signed-off-by: Bob Weinand <[email protected]>
@bwoebi
Handle signals weakly
0448387 
ZEND_SIGNALS may or may not be present in targets.

Signed-off-by: Bob Weinand <[email protected]>
@bwoebi
Small fixes
1939f76 
Signed-off-by: Bob Weinand <[email protected]>
@bwoebi
Avoid LOG() mechanism for logging in signal handler
75b2d7b 
Signed-off-by: Bob Weinand <[email protected]>
@bwoebi
Guard RC rereads by flag
fc223b2 
Signed-off-by: Bob Weinand <[email protected]>
@bwoebi
Guard RC rereads by flag
72b09d6 
Signed-off-by: Bob Weinand <[email protected]>
@bwoebi
Don't tie the exception replay rate limit globally
dfab868 
Otherwise concurrency in tests will lead to flakiness.

Signed-off-by: Bob Weinand <[email protected]>
@bwoebi
Fix root span data sending
b465cd8 
Signed-off-by: Bob Weinand <[email protected]>
@bwoebi
Add timeout for transmission to sidecar
ef0233d 
Signed-off-by: Bob Weinand <[email protected]>
@bwoebi
Move root_span_data sending so that it's always set to something init…
eef9b1c 
…ial within RINIT

Signed-off-by: Bob Weinand <[email protected]>
@bwoebi
Allow for select remote config manager config unloading
4915ee3 
Signed-off-by: Bob Weinand <[email protected]>
@bwoebi
Determine set of RC products and capabilities only once
ce8e05c 
Signed-off-by: Bob Weinand <[email protected]>
@bwoebi
Fix tests
30a547b 
Signed-off-by: Bob Weinand <[email protected]>
@bwoebi
Always submit queue_id initially
902dbe2 
Signed-off-by: Bob Weinand <[email protected]>
@bwoebi
Export sidecar log
de433b6 
Signed-off-by: Bob Weinand <[email protected]>
@bwoebi
Fix crash
a8768f6 
Signed-off-by: Bob Weinand <[email protected]>
@bwoebi bwoebi force-pushed the bob/live-debugger branch 4 times, most recently from 6dc88db to 6805e43 Compare October 1, 2024 19:42
@bwoebi
Xfail tests
30a3015 
Signed-off-by: Bob Weinand <[email protected]>
@bwoebi bwoebi force-pushed the bob/live-debugger branch 4 times, most recently from 4c61ac8 to 2e28bde Compare October 2, 2024 15:53
@bwoebi
Final update
19ac408 
Signed-off-by: Bob Weinand <[email protected]>
@bwoebi bwoebi force-pushed the bob/live-debugger branch from 2e28bde to 19ac408 Compare October 2, 2024 16:45
@bwoebi bwoebi merged commit f87446c into master Oct 2, 2024
@bwoebi bwoebi deleted the bob/live-debugger branch October 2, 2024 16:46
@github-actions github-actions Bot added this to the 1.4.0 milestone Oct 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@iamluc iamluc iamluc approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

1.4.0

Development

Successfully merging this pull request may close these issues.

3 participants

@bwoebi @codecov-commenter @iamluc