Skip to content

Enable sidecar trace sender on PHP 8.3#2729

Merged
bwoebi merged 7 commits intomasterfrom
julio/enable-sidecar-in-web-tests
Oct 3, 2024
Merged

Enable sidecar trace sender on PHP 8.3#2729
bwoebi merged 7 commits intomasterfrom
julio/enable-sidecar-in-web-tests

Conversation

@hoolioh
Copy link
Copy Markdown
Contributor

@hoolioh hoolioh commented Jun 21, 2024

Description

Reviewer checklist

  • Test coverage seems ok.
  • Appropriate labels assigned.

@pr-commenter
Copy link
Copy Markdown

pr-commenter Bot commented Jun 21, 2024 •
edited
Loading

Benchmarks

Benchmark execution time: 2024-06-25 08:57:59

Comparing candidate commit ea611a5 in PR branch julio/enable-sidecar-in-web-tests with baseline commit 231d5bd in branch master.

Found 1 performance improvements and 0 performance regressions! Performance is the same for 177 metrics, 0 unstable metrics.

scenario:PDOBench/benchPDOBaseline

  • 🟩 execution_time [-17.905µs; -14.470µs] or [-9.435%; -7.625%]

@bwoebi bwoebi force-pushed the julio/enable-sidecar-in-web-tests branch from ba3b980 to 7a2072f Compare October 2, 2024 16:51
@bwoebi bwoebi changed the title [Don't merge] enable sidecar in web tests Enable sidecar trace sender on PHP 8.3 Oct 2, 2024
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Oct 2, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.75%. Comparing base (f87446c) to head (9ea3c35).
Report is 1 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #2729      +/-   ##
============================================
- Coverage     80.91%   79.75%   -1.17%     
  Complexity     2526     2526              
============================================
  Files           146      146              
  Lines         14706    14706              
============================================
- Hits          11900    11729     -171     
- Misses         2806     2977     +171
Flag Coverage Δ
tracer-extension 78.10% <ø> (ø)
tracer-php 80.45% <ø> (-1.66%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 7 files with indirect coverage changes

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f87446c...9ea3c35. Read the comment docs.

@bwoebi bwoebi marked this pull request as ready for review October 2, 2024 19:30
@bwoebi bwoebi requested a review from a team as a code owner October 2, 2024 19:30
@bwoebi bwoebi force-pushed the julio/enable-sidecar-in-web-tests branch from bb58b00 to 0c36b6f Compare October 2, 2024 19:42
@bwoebi bwoebi force-pushed the julio/enable-sidecar-in-web-tests branch from 64ac8a7 to f4ea125 Compare October 3, 2024 17:59
@bwoebi bwoebi requested review from a team as code owners October 3, 2024 17:59
@bwoebi bwoebi force-pushed the julio/enable-sidecar-in-web-tests branch from f4ea125 to 9ea3c35 Compare October 3, 2024 18:11
@bwoebi bwoebi force-pushed the julio/enable-sidecar-in-web-tests branch from 9ea3c35 to c010d9f Compare October 3, 2024 20:05
@bwoebi bwoebi merged commit ee973a5 into master Oct 3, 2024
@bwoebi bwoebi deleted the julio/enable-sidecar-in-web-tests branch October 3, 2024 20:06
@github-actions github-actions Bot added this to the 1.4.0 milestone Oct 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bwoebi bwoebi bwoebi approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

1.4.0

Development

Successfully merging this pull request may close these issues.

4 participants

@hoolioh @codecov-commenter @bwoebi @pierotibou