Skip to content

Improve Linux dev setup#2720

Merged
iamluc merged 1 commit intomasterfrom
luc/improve-linux-dev-setup
Jun 18, 2024
Merged

Improve Linux dev setup#2720
iamluc merged 1 commit intomasterfrom
luc/improve-linux-dev-setup

Conversation

@iamluc
Copy link
Copy Markdown
Contributor

@iamluc iamluc commented Jun 18, 2024

Description

Our Docker dev setup is mainly designed for macOS.
This PR should help Linux users (as I am now), and change nothing for macOS users.

Reviewer checklist

  • Test coverage seems ok.
  • Appropriate labels assigned.

@iamluc iamluc requested a review from a team as a code owner June 18, 2024 12:13
@iamluc iamluc requested a review from hoolioh June 18, 2024 12:26
Copy link
Copy Markdown
Collaborator

@bwoebi bwoebi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It feels like it's the wrong solution to a problem (chowning permissions in the container? on each container start?) - anyway, if it works for you, go ahead merging it.

@iamluc
Copy link
Copy Markdown
Contributor Author

iamluc commented Jun 18, 2024

chowning permissions in the container?

The important part is usermod/groupmod.
Chowning is secondary but useful to copy the compiled extension in /opt, like when running make install

@iamluc iamluc merged commit 59d1238 into master Jun 18, 2024
@iamluc iamluc deleted the luc/improve-linux-dev-setup branch June 18, 2024 16:28
@github-actions github-actions Bot added this to the 1.2.0 milestone Jun 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants